severity 355887 normal retitile 355887 typespeed segfault if $HOME is unset. thanks
On Mon, Apr 24, 2006 at 10:20:44PM +0300, Niko Tyni wrote:
> tags 355887 patch
> thanks
>
> On Thu, Mar 09, 2006 at 12:08:07AM -0800, Steve Langasek wrote:
> > On Thu, Mar 09, 2006 at 07:05:00AM +0100, Malte Schirmacher wrote:
> >
> > > Well trying to install it the same error occurs like in the other report:
> >
> > Ok, well, the strace you forwarded clearly didn't come from an instance in
> > which typespeed segfaulted.
>
> Hi,
>
> I believe I have found the cause of the segfault. It happens when $HOME
> is not set. The readconfig() function in files.c uses getenv("HOME")
> without checking if it's NULL.
>
> The HOME environment variable may have been unset for the bug reporter
> because of the recent sudo issues. With sudo 1.6.8p7-1.3, which was the
> current version at the time this bug was reported, HOME indeed becomes
> unset. Then 'typespeed --makescores' segfaults in the postinst when using
>
> % sudo apt-get install typespeed
>
>
> I'm attaching a trivial patch that fixes this. It skips reading the
> user-specific configuration file if $HOME is not set.
$HOME beeing unset because of sudo has been fixed in all distros. this
bug does not deserve an RC severity, it's merely normal as having $HOME
unset is very uncommon, and very un-advised.
--
·O· Pierre Habouzit
··O [EMAIL PROTECTED]
OOO http://www.madism.org
signature.asc
Description: Digital signature
