On 9/13/23 17:42, Thomas Goirand wrote:
On 9/13/23 13:43, Adam Cecile wrote:
On 9/13/23 12:55, Thomas Goirand wrote:
On 9/12/23 18:16, Adam Cecile wrote:
Hello,
No hurry, I think we might want to wait for upstream to respond to
my PR regarding double awaitable fix.
It is indeed lextudio upstream that took over the PySNMP package
and all patches are coming from us (except mine ofc).
Regards, Adam.
Because it messes up the order in which people normally read text.
Why is top-posting such a bad thing?
Top-posting.
What is the most annoying thing in e-mail?
Hello, you started first !
LOL ! :)
Well, I was on my phone, sorry for that ... :P
Thanks! :)
I tried applying your patch at
https://salsa.debian.org/acecile-guest/python-pysnmp4/-/commit/88d40f1225de8f7b42413b56206b41a6155fcf09
Unfortunately, it doesn't apply on top of 4.4.12-2, which is the
current version of the package (in Bookworm, Unstable and Testing).
Would you be able to rebase your patch on top of 4.4.12-2? Then I'll
do the work to get this into Bookworm (and Unstable/Testing).
Cheers,
Thomas Goirand (zigo)
Yes that's expected.
Well, how can I then apply it to the version in Bookworm?
Hello,
Soory for the delay, I don't get the question, bookworm version is the
same as unstable at the moment so my debian/4.4.12-3 branch also works:
https://salsa.debian.org/acecile-guest/python-pysnmp4/-/commits/debian/4.4.12-3
If you want only the full patch fixing asyncio, you can find it as
debian/patch:
https://salsa.debian.org/acecile-guest/python-pysnmp4/-/blob/debian/4.4.12-3/debian/patches/0003-Merge-lextudio-upstream-fork-patch-related-to-asynci.patch
This commit is only to fix double awaitable "new" upstream bug. It
depends on a large amount of backported commits to fix asyncio /
Python 3.11 support.
Could you backport it to 4.4.12-2 as in Bookworm and Unstable?
As I wrote already, I already packaged python-pysnmp-lextudio, which
is currently in the NEW queue. I will be happy to apply your patch in
there, but IMO, we should treat pysnmp-lextudio as a different source
and binary package (my binary conflicts with python3-pysnmp4), because
the dependency chain is very different.
Yes it's already done, see above.
You can see here a branch created from upstream 4.4.12 tag with
asyncio patches cherry-pick from new upstream master:
https://salsa.debian.org/acecile-guest/python-pysnmp4/-/commits/4.4.12+cherry-pick-asyncio-lextudio-fixes/
It has then been squashed into a single debian/patch:
https://salsa.debian.org/acecile-guest/python-pysnmp4/-/commit/a5f17d27c7813dbdb64cdf674d1855a77c3eb0f0
Ah, super cool! It's too late for today (have to go back home), so
I'll work on this tomorrow. Thanks a lot for your contrib.
So, all good?
BTW, we've been using your MegaCli repo (we mirror it), and I also
would like to thank you for this. :)
Thanks! Sadly I miss time to take care of it, but no matter how old and
badly written was the Python code, it still works flawlessly :-) Cheers
to LSI/Broadcom for not breaking tools and output format btw.
I made my own forked repository because I'm unsure how we should
proceed, but I can easily push the debian/4.4.12-3 tag to the regular
Python module repository on Salsa.
4.4.12-3 will be for Unstable. For Stable, it's going to be something
like 4.4.12-2+deb12u1, as per the normal process, and it will have to
be (pre-)approved by the Debian Stable release team by filling a bug
against release.debian.org. No worries, I do understand that Debian
procedures are not easy to understand, though I'm happy to explain if
you need.
Cheers,
Thomas Goirand (zigo)
