Control: tags -1 - moreinfo

Hi Christoph,

On Mon, Sep 25, 2023 at 10:30:41PM +0200, Christoph Biedl wrote:
> Control: tags 1052632 moreinfo
> 
> Helmut Grohne wrote...
> 
> > We want to change the value of systemdsystemunitdir in systemd.pc to
> > point below /usr. clevis' upstream build system consumes this value, but
> > the debian packaging hard codes its current value. When it changes,
> > clevis will fail to build from source. Consider applying the attached
> > patch to avoid that.
> 
> While I'm certainly willing to help with everything that helps to end
> the usrmerge mess, I'm a little confused when comparing this with the
> recent changes requested in #1052278
> 
> Mind to give a hint what I should do? Drop the version in experimental
> and use that one instead? Or ...?

Hahaha. -ETOOMANYBUGS

So what happened here is that I looked into a /usr-merge conversion for
a few example packages and clevis happened to be picked randomly. I then
noticed that there were very many such packages and looked for ways to
convert them using binNMUs. There are two things that we can adapt
easily and those are dh_installsystemd (and where it chooses to place
units) and systemd.pc. So I started a partial archive rebuild with these
two modifications and clevis happened to fail. I totally forgot about
that earlier patch by then.

So this bug is real. Even with #1052278 applied, clevis will FTBFS when
systemd.pc changes. With this patch applied, we can perform the
equivalent of #1052278 by changing systemd.pc and then binNMUing clevis
(with the same effect as #1052278 on restructuring changes causing
breakage).

Given the additional insights gained now, I recommend dropping #1052278
and using this patch only. Rationale:
 * This patch achieves the same effect although with a little more
   delay at the time of my choosing.
 * #1052278 needs to be reverted when backporting clevis to bookworm,
   but this patch will not break backports.

I'm sorry for the back and forth. Thanks for bearing with me.

Helmut

Reply via email to