Source: network-manager-strongswan
Version: 1.6.0-2.1
Severity: wishlist
Tags: patch
User: bi...@debian.org
Usertags: nm-libexec

Hi,

your package installs helper binaries that are currently located in
/usr/lib/NetworkManager.
Now that Debian policy allows to install such binaries into
/usr/libexec, it was requested in [1] that the network-manager package
is updated to use this location to align with other distros and avoid
unnecessary friction.

The network-manager package and the vpn packages maintained by the
pkg-utopia team have been updated accordingly.

For consistencies sake, please consider applying the attached patch,
which moves the helper binaries to /usr/libexec.

While at it, I took the liberty to disable static libraries and stop
installing libtool .la files. Those are only useful if you build public
system libraries, which is not the case here.
Dropping those unnecessary files will significantly reduce the size of
the package.


Thanks,
Michael


[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026388
diff -Nru network-manager-strongswan-1.6.0/debian/changelog 
network-manager-strongswan-1.6.0/debian/changelog
--- network-manager-strongswan-1.6.0/debian/changelog   2023-10-02 
18:51:54.000000000 +0200
+++ network-manager-strongswan-1.6.0/debian/changelog   2023-10-21 
13:18:08.000000000 +0200
@@ -1,3 +1,12 @@
+network-manager-strongswan (1.6.0-2.2) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Install helper binaries into /usr/libexec (Closes: #-1)
+  * Disable static libraries, those are not needed and only take up space
+  * Remove libtool *.la files, those are not useful as well
+
+ -- Michael Biebl <bi...@debian.org>  Sat, 21 Oct 2023 13:18:08 +0200
+
 network-manager-strongswan (1.6.0-2.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru network-manager-strongswan-1.6.0/debian/rules 
network-manager-strongswan-1.6.0/debian/rules
--- network-manager-strongswan-1.6.0/debian/rules       2023-10-02 
18:51:51.000000000 +0200
+++ network-manager-strongswan-1.6.0/debian/rules       2023-10-21 
13:18:08.000000000 +0200
@@ -8,10 +8,13 @@
        dh $@
 
 override_dh_auto_configure:
-       dh_auto_configure -- --with-gtk4 --without-libnm-glib 
--with-charon=/usr/lib/ipsec/charon-nm 
--libexecdir="\$$(prefix)/lib/NetworkManager"
+       dh_auto_configure -- --with-gtk4 --without-libnm-glib 
--with-charon=/usr/lib/ipsec/charon-nm --disable-static
 
 override_dh_clean:
        dh_clean -XNetworkManager-strongswan.metainfo.xml 
nm-strongswan-service.name
 
 override_dh_makeshlibs:
        dh_makeshlibs -X/usr/lib/NetworkManager/
+
+execute_before_dh_install:
+       find debian/network-manager-strongswan -name '*.la' -print -delete

Reply via email to