Source: xrootd
Version: 5.6.3-2
Severity: normal
Tags: ftbfs patch
Dear Maintainer,
Build fails here:
[ 99%] Building CXX object
tests/XrdClTests/CMakeFiles/XrdClTests.dir/OperationsWorkflowTest.cc.o
cd /<<PKGBUILDDIR>>/obj-hppa-linux-gnu/tests/XrdClTests && /usr/bin/c++
-DHAVE_ATOMICS -DHAVE_CRYPT -DHAVE_CURL_MULTI_WAIT -DHAVE_DH_PADDED
-DHAVE_ET_COM_ERR_H -DHAVE_FSTATAT -DHAVE_FUSE -DHAVE_GETHBYXR
-DHAVE_GETIFADDRS -DHAVE_LIBZ -DHAVE_NAMEINFO -DHAVE_PROTOR -DHAVE_READLINE
-DHAVE_SENDFILE -DHAVE_SETRESUID -DHAVE_SHADOWPW -DHAVE_SIGWTI -DHAVE_SSL
-DHAVE_SYSTEMD -DHAVE_XML2 -DHAVE_XRDCRYPTO -DXRDPLUGIN_SOVERSION=\"5\"
-DXrdClTests_EXPORTS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE
-D_LARGEFILE_SOURCE -I/<<PKGBUILDDIR>>/obj-hppa-linux-gnu/src
-I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>>/tests/XrdClTests/../common -g -O2
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -Wformat -Werror=format-security
-Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter
-std=gnu++14 -fPIC -MD -MT
tests/XrdClTests/CMakeFiles/XrdClTests.dir/OperationsWorkflowTest.cc.o -MF
CMakeFiles/XrdClTests.dir/OperationsWorkflowTest.cc.o.d -o
CMakeFiles/XrdClTests.dir/OperationsWorkflowTest.cc.o -c
/<<PKGBUILDDIR>>/tests/XrdClTests/OperationsWorkflowTest.cc
In file included from /usr/include/fcntl.h:342,
from
/<<PKGBUILDDIR>>/tests/XrdClTests/LocalFileHandlerTest.cc:25:
In function ‘int open(const char*, int, ...)’,
inlined from ‘void LocalFileHandlerTest::WriteMkdirTest()’ at
/<<PKGBUILDDIR>>/tests/XrdClTests/LocalFileHandlerTest.cc:210:17:
/usr/include/hppa-linux-gnu/bits/fcntl2.h:50:31: error: call to
‘__open_missing_mode’ declared with attribute error: open with O_CREAT or
O_TMPFILE in second argument needs 3 arguments
50 | __open_missing_mode ();
| ~~~~~~~~~~~~~~~~~~~~^~
make[4]: *** [tests/XrdClTests/CMakeFiles/XrdClTests.dir/build.make:205:
tests/XrdClTests/CMakeFiles/XrdClTests.dir/LocalFileHandlerTest.cc.o] Error 1
Full log is here:
https://buildd.debian.org/status/fetch.php?pkg=xrootd&arch=hppa&ver=5.6.3-2&stamp=1698540721&raw=0
It's a puzzle why the package doesn't fail to build on other architectures
but adding a mode argument to LocalFileHandlerTest.cc:210 fixes build. See
attached patch. Probably, it would be better to fix flags argument.
Regards,
Dave Anglin
-- System Information:
Debian Release: trixie/sid
APT prefers buildd-unstable
APT policy: (500, 'buildd-unstable'), (500, 'unstable')
Architecture: hppa (parisc64)
Kernel: Linux 6.1.60+ (SMP w/4 CPU threads)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
--- ./tests/XrdClTests/LocalFileHandlerTest.cc.save 2023-10-29
01:22:07.198005340 +0000
+++ ./tests/XrdClTests/LocalFileHandlerTest.cc 2023-10-29 01:22:23.998124928
+0000
@@ -207,7 +207,7 @@
//----------------------------------------------------------------------------
// Read file with POSIX calls to confirm correct write
//----------------------------------------------------------------------------
- int fd = open( targetURL.c_str(), flags );
+ int fd = open( targetURL.c_str(), flags, mode );
int rc = read( fd, buffer, writeSize );
CPPUNIT_ASSERT_EQUAL( rc, int( writeSize ) );
std::string read( buffer, writeSize );
