On Fri, 2023-11-17 at 08:40 +0100, Bastian Venthur wrote: > If bash completion is not enabled on purpose, I would > consider this behaviou a bug. But I believe just enabling the bash > completion > by default would be the better solution.
In any case, please do not enable the fzf-completion (i.e. **<TAB>) by default, unless there's an easy way to manually disable that (which is not easy if the file is installed to /usr/share/bash- completion/completions/fzf ) The problem with fzf’s completion file is, that it contains both: 1. the completion for the fzf program itself 2. the "generic" (well only to some very limited amount) **<TAB> completion The latter is unfortunately rather limited and even buggy in many cases. I tried to get that improved, but upstream eventually decided that he doesn't want the functionality to be expanded/fixed. Alternative integrations exist, but these do not work properly when fzf’s own is also enabled. Therefore, please stop installing the completion file to: /usr/share/bash-completion/completions/fzf This is anyway not an appropriate location, as neither of the two completions mentioned above actually use bash-completion. IMO the proper way would be: - users need to manually source (2) (or manually install it in /etc/profile.d or the likes) - the parts for (1) should be split of into a separate file and that could actually be installed into /usr/share/bash-completion/completions/ (not because it would really use anything of bash-completion, but only to get the opportunistic loading of that) I've had talked to upstream about splitting the two (https://github.com/junegunn/fzf/issues/3457), but again... he does not seem to have much interest in improving things. If you really need to have fzf's completion file automatically loaded, please add some easy way to disable that. Otherwise you break the setup of people who want to use better alternative integrations. Cheers, Chris.
