Bug#1056569: libbrotli-dev: libbrotlidec.a corrupted due to c-p error in 0001-build-static-libraries-by-default.patch

[Gianfranco Costamagna]

control: severity -1 serious
control: tags -1 patch pending

This is actually regressing freetype autopkgtests

I'll team upload shortly the trivial patch

G.
On Thu, 23 Nov 2023 10:12:43 +0100 Philipp Wolski <xis...@tlen.pl> wrote:

Package: libbrotli-dev
Version: 1.1.0-1
Severity: normal

Dear Maintainer,

libbrotlidec.a is unusable in brotli 1.1.0-1 since it is identical to 
libbrotlicommon.a

This happened because patch 0001-build-static-libraries-by-default.patch seems 
to contain
a copy paste error:
+add_library(brotlicommon-static STATIC ${BROTLI_COMMON_SOURCES})
+add_library(brotlidec-static STATIC ${BROTLI_COMMON_SOURCES})
+add_library(brotlienc-static  STATIC ${BROTLI_ENC_SOURCES})






-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-4-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libbrotli-dev depends on:
ii  libbrotli1  1.1.0-1

libbrotli-dev recommends no packages.

libbrotli-dev suggests no packages.

-- no debconf information

I rebuild the package with the line of brotlidec-static changed to BROTLI_DEC_SOURCES and the library is usable again. I caught the problem because I tried to link libfreetype statically which required libbrotlidec.a

OpenPGP_signature.asc
Description: OpenPGP digital signature