Hi,
This is starting to look great, thanks a lot of all the work. :-) However, I
still see a few issues with it:
- the references to C-BIOS in the XML configuration files should not be
removed. When running, they are usually availably from the cbios package.
And if the user didn't install that, OpenMSX will detect this and handle it
properly.
- The bundled catch2 should not be used. So the proper solution would be to
port the code to the newer version, and to keep the bundled version out of
it. Using the bundled version is acceptable as a temporary solution, but if
we do that, we should file a bug report that the packaged version should be
used again.
- I prefer to not override the source-is-missing lintian messages. The reason
is that there are 3 kinds of messages, each with their own solution:
1. An actual bug in the code. The solution is to fix the code.
2. A bug in Lintian. This code should not trigger the message. The solution
is to fix Lintian.
3. A special (and rare) case. This code should not trigger the message, but
it is unreasonable to expect Lintian to understand that. The solution is
to add an override.
IMO what we have here is 2, not 3. Adding an override implies that there is
nothing wrong with Lintian's behavior, which is incorrect; there is a bug
filed against Lintian for this and it should be fixed there. Unused overrides
can unexpectedly hide actual problems, so when it gets fixed in Lintian, the
overrides need to be removed, but it is unlikely that anyone will think of
this, because there will not be a notification that the bug is fixed.
Because of all this, I prefer to not silence Lintian. The messages do
indicate an actual bug, it's just not in this package.
Thanks,
Bas
On Wed, Nov 29, 2023 at 06:50:59PM -0600, Aaron Rainbolt wrote:
> Alright, here's the latest openMSX package with all C-BIOS binaries patched
> out. Now that there's no new binaries, I can just send this as a debdiff
> attachment. Keep in mind all the binary files mentioned in the diff have to
> be deleted from the source tree.
>
> Thanks for collaborating with me so we could come up with the best solution
> possible for this! The debdiff is attached.
>
> --
> Aaron Rainbolt
> Lubuntu Developer
> Matrix: @arraybolt3:matrix.org
> IRC: arraybolt3 on irc.libera.chat
> GitHub: https://github.com/ArrayBolt3
