Control: tag -1 + pending
Hi Yavor,
sorry for the late reply, but I only managed to continue on this now
as I'm on holidays now.
Yavor Doganov wrote:
> Here it is -- no memory leaks and I could not obtain crash or abort
> with the logs I've tested. Note that while my original patch
> introduced some leaks, it also fixes some in the original code.
Thanks again for these patches! They indeed work much better than
before this set of patches. I though got another crash on this line:
Dec 24 06:43:16 c6 kernel: net_ratelimit: 1 callbacks suppressed
I think I managed to fix it and will also upload, but I'd be happy for
a short review of yours:
Backtrace is as follows:
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `ccze -A'.
Program terminated with signal SIGABRT, Aborted.
#0 __pthread_kill_implementation (threadid=<optimized out>,
signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
44 ./nptl/pthread_kill.c: No such file or directory.
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>,
signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
#1 0x00007fe6a065715f in __pthread_kill_internal (signo=6, threadid=<optimized
out>) at ./nptl/pthread_kill.c:78
#2 0x00007fe6a0609472 in __GI_raise (sig=sig@entry=6) at
../sysdeps/posix/raise.c:26
#3 0x00007fe6a05f34b2 in __GI_abort () at ./stdlib/abort.c:79
#4 0x00007fe6a05f41ed in __libc_message (fmt=fmt@entry=0x7fe6a076678c "%s\n")
at ../sysdeps/posix/libc_fatal.c:150
#5 0x00007fe6a0660a75 in malloc_printerr (str=str@entry=0x7fe6a076422c
"free(): invalid pointer") at ./malloc/malloc.c:5658
#6 0x00007fe6a06627f4 in _int_free (av=<optimized out>, p=<optimized out>,
have_lock=have_lock@entry=0) at ./malloc/malloc.c:4432
#7 0x00007fe6a066516f in __GI___libc_free (mem=<optimized out>) at
./malloc/malloc.c:3367
#8 0x00007fe6a05b6467 in ccze_syslog_process (offsets=0x558834ff3170) at
./src/mod_syslog.c:97
#9 ccze_syslog_handle (str=<optimized out>, length=<optimized out>,
rest=0x7fffc99b28c8) at ./src/mod_syslog.c:134
#10 0x0000558833642a2f in ccze_plugin_run
(pluginset=pluginset@entry=0x558834fefd30,
subject=subject@entry=0x558834fe59c0 "Dec 24 06:43:16 c6 kernel:
net_ratelimit: 1 callbacks suppressed", subjlen=64,
rest=rest@entry=0x7fffc99b28c8,
type=type@entry=CCZE_PLUGIN_TYPE_FULL,
handled=handled@entry=0x7fffc99b28a4, status=0x7fffc99b28a8) at
./src/ccze-plugin.c:327
#11 0x0000558833640616 in ccze_main () at ./src/ccze.c:706
#12 main (argc=<optimized out>, argv=<optimized out>) at ./src/ccze.c:756
Commenting out the "free (process);" in line 97 of src/mod_syslog.c
via the pcre2.patch seems to have fixed that:
https://salsa.debian.org/debian/ccze/-/commit/11b90155a6559e2121836483c2acacf35d8fca3b
Do you think that change would have any other impact? At least no more
crashes, so I'll upload anyway. But if you find some drawbacks, please
tell me.
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
