Control: reassign -1 debhelper 13.11.9
Control: affects -1 src:wireshark
Control: tags -1 patch
Hi Lucas,
Thank you for the archive-wide test and reporting.
I believe the best would be fixing this in debhelper.
Please see the attached patch and the MR on Salsa:
https://salsa.debian.org/debian/debhelper/-/merge_requests/120
Cheers,
Balint
Lucas Nussbaum <lu...@debian.org> ezt írta (időpont: 2023. aug. 13., V, 21:21):
>
> Source: wireshark
> Version: 4.0.7-1
> Severity: minor
> Tags: trixie sid ftbfs
> User: lu...@debian.org
> Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
> User: debian...@lists.debian.org
> Usertags: qa-doublebuild
>
> Hi,
>
> This package fails to build a source package after a successful build
> (dpkg-buildpackage ; dpkg-buildpackage -S).
>
> This is probably a clear violation of Debian Policy section 4.9 (clean
> target),
> but this is filed as severity:minor for now, because a discussion on
> debian-devel showed that we might want to revisit the requirement of a working
> 'clean' target.
>
> More information about this class of issues, included common problems and
> solutions, is available at
> https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild
>
> Relevant part of the build log:
> > cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage
> > --sanitize-env -us -uc -rfakeroot -S
> > -------------------------------------------------------------------------------------------------------------------------
> >
> > dpkg-buildpackage: info: source package wireshark
> > dpkg-buildpackage: info: source version 4.0.7-1
> > dpkg-buildpackage: info: source distribution unstable
> > dpkg-buildpackage: info: source changed by Balint Reczey
> > <bal...@balintreczey.hu>
> > dpkg-source --before-build .
> > debian/rules clean
> > dh clean --with python3 --buildsystem cmake
> > dh_auto_clean -O--buildsystem=cmake
> > dh_autoreconf_clean -O--buildsystem=cmake
> > debian/rules override_dh_clean
> > make[1]: Entering directory '/<<PKGBUILDDIR>>'
> > dh_clean
> > # ignore #653916
> > blhc: ignore-line-regexp: .*CMakeCXXCompilerABI.cpp .*
> > make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> > dpkg-source -b .
> > dpkg-source: info: using source format '3.0 (quilt)'
> > dpkg-source: info: building wireshark using existing
> > ./wireshark_4.0.7.orig.tar.gz
> > dpkg-source: info: using patch list from debian/patches/series
> > dpkg-source: error: cannot represent change to
> > test/__pycache__/fixtures.cpython-311.pyc: binary file contents changed
> > dpkg-source: error: add test/__pycache__/fixtures.cpython-311.pyc in
> > debian/source/include-binaries if you want to store the modified binary in
> > the debian tarball
> ...
> > dpkg-source: error: unrepresentable changes to source
> > dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
> >
> > E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage
> > --sanitize-env -us -uc -rfakeroot -S' failed to run.
>
>
> The full build log is available from:
> http://qa-logs.debian.net/2023/08/13/wireshark_4.0.7-1_unstable.log
>
> If you reassign this bug to another package, please mark it as 'affects'-ing
> this package. See https://www.debian.org/Bugs/server-control#affects
>
> If you fail to reproduce this, please provide a build log and diff it with
> mine
> so that we can identify if something relevant changed in the meantime.
From 6e52fc95a8b4e38ee6a1ac31d53446e0a97179e3 Mon Sep 17 00:00:00 2001
From: Balint Reczey <bal...@balintreczey.hu>
Date: Sun, 7 Jan 2024 12:20:36 +0100
Subject: [PATCH] dh_clean: Clean __pycache__
Closes: #1048890
---
dh_clean | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dh_clean b/dh_clean
index beb67c49..a11d09c5 100755
--- a/dh_clean
+++ b/dh_clean
@@ -24,8 +24,8 @@ assume that B<dh_clean> will clean up after them.
It removes the package build directories, and removes some other files including
F<debian/files>, and any detritus left behind by other debhelper commands. It
-also removes common files that should not appear in a Debian diff:
- #*# *~ DEADJOE *.orig *.rej *.SUMS TAGS .deps/* *.P *-stamp
+also removes common files and directories that should not appear in a Debian diff:
+ #*# *~ DEADJOE *.orig *.rej *.SUMS __pycache__ TAGS .deps/* *.P *-stamp
It does not run "make clean" to clean up after the build process. Use
L<dh_auto_clean(1)> to do things like that.
@@ -178,7 +178,7 @@ if (! $dh{D_FLAG}) {
-o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \\
-o -name TAGS -o \\( -path '*/.deps/*' -a -name '*.P' \\) \\
\\) -exec rm -f {} + \\) -o \\
- \\( -type d -a -name autom4te.cache -prune -exec rm -rf {} + \\) \\)");
+ \\( -type d -a \\( -name autom4te.cache -o -name __pycache__ \\) -prune -exec rm -rf {} + \\) \\)");
}
if (!compat(6) && !$dh{K_FLAG}) {
--
2.40.1
