On Tue, Jan 30, 2024 at 04:27:49PM -0500, Robert Edmonds wrote: > I guess you have to do it that way since there isn't really anything > universal and machine readable that says: this is the public API header > file to include to use this library.
Exactly. Though there are good practices (I hesitate to say "best") that would make headers no-ops if included directly when they shouldn't be, etc. > > This shows there are headers that can't be compiled because they're > > Windows-specific. So it seems counterproductive to ship these at all in > > Debian? > > If this header were removed from the package, or if a quirk were added to > > https://salsa.debian.org/vorlon/armhf-time_t/-/blob/main/check-armhf-time_t?ref_type=heads > > to exclude the incorrect headers from the analysis, we could confirm that > > avro-c is unaffected and avoid unnecessary NMUs / transitions to unstable. > If there is a way to quirk the avro-c package for this analysis so you > only include /usr/include/avro.h rather than every header file shipped > in the -dev package I think it would let your analysis succeed, without > missing anything, and, I would guess that that analysis would show no > ABI changes and thus no ABI transition is necessary. > I'm also open to just dropping those ms*.h files from the -dev package > which should just work without any other changes without breaking > anything else, but I haven't tested it. It looks like my colleague has already re-tested (with a local change, not yet published to either of https://salsa.debian.org/vorlon/armhf-time_t/ or https://salsa.debian.org/adrien-n/armhf-time_t/) and confirmed that avro-c's ABI is unaffected. (It's important to confirm with a full compile test because there are a number of types besides bare time_t that could be affected and overlooked with a bare grep or so.) We will make sure that this gets fully integrated into the published test results and that avro-c does not get NMUed to unstable for this. In the meantime I suggest leaving this bug report open for tracking. Thanks, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: PGP signature
