grr, sent too soon (do I need coffee?) On 29-02-2024 8:33 a.m., Paul Gevers wrote:
Hi,On 21-02-2024 10:53 p.m., Dalton Durst wrote:This condition only occurs when both source packages are considerable for migration. If both source packages provide both binaries, pkgb is found to supersede pkga, so pkga is not considered for migration. If pkgb passes all policy, it will migrate and pkga will probably be forgotten about (even though it considers pkgb its own cruft). This may be expected behavior,Expected behavior in the sense that once src:pkgb migrates, it's OK to forget about bin:takeover from src:pkga. I think *ideally* britney2 would migrate the binNMU from src:pkga while src:pkgb is blocked, but I think it's a niche case that is acceptable to not support. What would be bad is if bin:takeover from src:pkgb migrates without src:pkgb (bug 709460).
>
but I exposed it in the bug-709460 test case while trying to enable britney to check architecture-independent packages. Currently the behavior is masked in that case because britney skips the -doc package due to it being arch-indep. If this _is_ expected behavior, bug-709460 is currently passing erroneously.Which means that, if we fix bug 1064428 with your proposal to just skip the check, we need to add other code to prevent reintroduction of bug 709460. Either properly migrating bin:takeover from src:pkga, or by blocking bin:takeover altogether (this bug). Depending on required complexity [1], I don't think it's bad if we would end up wontfix-ing this bug (#1064427)
I forgot it's important here to reason about arch:all vs arch:$any. In case bin:takeover is arch:all there will not be an binNMU of it, so there's no version of it that needs to migrate as long as src:pkgb is blocked.
[1] I haven't inspected the code yet, but keeping track of all binary versions and reason about them instead of just taking the highest version seems like a large paradigm shift in britney2 (but I could be wrong).
This still holds though. Paul
OpenPGP_signature.asc
Description: OpenPGP digital signature
