Source: motif
Version: 2.3.8-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. 
> -I../../include -I.. -I./.. -DXMBINDDIR_FALLBACK=\"/usr/share/X11/bindings\" 
> -DINCDIR=\"/usr/include/X11\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu/X11\" 
> -DX11RGBPATH=\"/etc/X11/rgb.txt\"   -Wdate-time -D_FORTIFY_SOURCE=2  
> -I/usr/include/freetype2 -I/usr/include/libpng16   -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FILE_OFFSET_BITS=64 -Wall -g 
> -fno-strict-aliasing -Wno-unused -Wno-comment -I/usr/include/freetype2 
> -I/usr/include/libpng16    -c -o XpmCrBufFrP.lo XpmCrBufFrP.c
> XpmCrBufFrI.c: In function ‘XmeXpmCreateBufferFromXpmImage’:
> XpmCrBufFrI.c:155:5: error: implicit declaration of function ‘strcpy’ 
> [-Werror=implicit-function-declaration]
>   155 |     strcpy(ptr, buf);
>       |     ^~~~~~
> XpmCrBufFrI.c:47:1: note: include ‘<string.h>’ or provide a declaration of 
> ‘strcpy’
>    46 | #include "XpmI.h"
>   +++ |+#include <string.h>
>    47 | 
> XpmCrBufFrI.c:155:5: warning: incompatible implicit declaration of built-in 
> function ‘strcpy’ [-Wbuiltin-declaration-mismatch]
>   155 |     strcpy(ptr, buf);
>       |     ^~~~~~
> XpmCrBufFrI.c:155:5: note: include ‘<string.h>’ or provide a declaration of 
> ‘strcpy’
> XpmCrBufFrI.c: In function ‘WriteColors’:
> XpmCrBufFrI.c:292:9: error: implicit declaration of function ‘strncpy’ 
> [-Werror=implicit-function-declaration]
>   292 |         strncpy(s, *defaults++, cpp);
>       |         ^~~~~~~
> XpmCrBufFrI.c:292:9: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
> XpmCrBufFrI.c:292:9: warning: incompatible implicit declaration of built-in 
> function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
> XpmCrBufFrI.c:292:9: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
> XpmCrBufFrI.c:312:9: warning: incompatible implicit declaration of built-in 
> function ‘strcpy’ [-Wbuiltin-declaration-mismatch]
>   312 |         strcpy(s, "\",\n");
>       |         ^~~~~~
> XpmCrBufFrI.c:312:9: note: include ‘<string.h>’ or provide a declaration of 
> ‘strcpy’
> XpmCrBufFrI.c:316:45: error: implicit declaration of function ‘strlen’ 
> [-Werror=implicit-function-declaration]
>   316 |            (*data_size + l - *used_size) <= strlen(buf))
>       |                                             ^~~~~~
> XpmCrBufFrI.c:316:45: note: include ‘<string.h>’ or provide a declaration of 
> ‘strlen’
> XpmCrBufFrI.c:316:45: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
> XpmCrBufFrI.c:316:45: note: include ‘<string.h>’ or provide a declaration of 
> ‘strlen’
> XpmCrBufFrI.c: In function ‘WritePixels’:
> XpmCrBufFrI.c:352:13: warning: incompatible implicit declaration of built-in 
> function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
>   352 |             strncpy(s, colors[*pixels].string, cpp); /* how can we 
> trust *pixels? :-\ */
>       |             ^~~~~~~
> XpmCrBufFrI.c:352:13: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
> XpmCrBufFrI.c:357:9: warning: incompatible implicit declaration of built-in 
> function ‘strcpy’ [-Wbuiltin-declaration-mismatch]
>   357 |         strcpy(s, "\",\n");
>       |         ^~~~~~
> XpmCrBufFrI.c:357:9: note: include ‘<string.h>’ or provide a declaration of 
> ‘strcpy’
> XpmCrBufFrI.c:365:9: warning: incompatible implicit declaration of built-in 
> function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
>   365 |         strncpy(s, colors[*pixels].string, cpp); /* how can we trust 
> *pixels? */
>       |         ^~~~~~~
> XpmCrBufFrI.c:365:9: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
> XpmCrBufFrI.c: In function ‘ExtensionsSize’:
> XpmCrBufFrI.c:385:17: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>   385 |         size += strlen(ext->name) + 11;
>       |                 ^~~~~~
> XpmCrBufFrI.c:385:17: note: include ‘<string.h>’ or provide a declaration of 
> ‘strlen’
> XpmCrBufFrI.c: In function ‘WriteExtensions’:
> XpmCrBufFrI.c:428:5: warning: incompatible implicit declaration of built-in 
> function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
>   428 |     strncpy(s, ",\n\"XPMENDEXT\"", data_size - (s-dataptr)-1);
>       |     ^~~~~~~
> XpmCrBufFrI.c:428:5: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
> XpmCrBufFrI.c: In function ‘CommentsSize’:
> XpmCrBufFrI.c:441:21: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>   441 |         size += 5 + strlen(info->hints_cmt);
>       |                     ^~~~~~
> XpmCrBufFrI.c:441:21: note: include ‘<string.h>’ or provide a declaration of 
> ‘strlen’
> XpmCrBufFrI.c:444:21: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>   444 |         size += 5 + strlen(info->colors_cmt);
>       |                     ^~~~~~
> XpmCrBufFrI.c:444:21: note: include ‘<string.h>’ or provide a declaration of 
> ‘strlen’
> XpmCrBufFrI.c:447:21: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>   447 |         size += 5 + strlen(info->pixels_cmt);
>       |                     ^~~~~~
> XpmCrBufFrI.c:447:21: note: include ‘<string.h>’ or provide a declaration of 
> ‘strlen’
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../include -I.. -I./.. 
> -DXMBINDDIR_FALLBACK=\"/usr/share/X11/bindings\" 
> -DINCDIR=\"/usr/include/X11\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu/X11\" 
> -DX11RGBPATH=\"/etc/X11/rgb.txt\" -Wdate-time -D_FORTIFY_SOURCE=2 
> -I/usr/include/freetype2 -I/usr/include/libpng16 -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FILE_OFFSET_BITS=64 -Wall -g 
> -fno-strict-aliasing -Wno-unused -Wno-comment -I/usr/include/freetype2 
> -I/usr/include/libpng16 -c XpmRdFToBuf.c  -fPIC -DPIC -o .libs/XpmRdFToBuf.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../include -I.. -I./.. 
> -DXMBINDDIR_FALLBACK=\"/usr/share/X11/bindings\" 
> -DINCDIR=\"/usr/include/X11\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu/X11\" 
> -DX11RGBPATH=\"/etc/X11/rgb.txt\" -Wdate-time -D_FORTIFY_SOURCE=2 
> -I/usr/include/freetype2 -I/usr/include/libpng16 -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FILE_OFFSET_BITS=64 -Wall -g 
> -fno-strict-aliasing -Wno-unused -Wno-comment -I/usr/include/freetype2 
> -I/usr/include/libpng16 -c XpmWrFFrI.c  -fPIC -DPIC -o .libs/XpmWrFFrI.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../include -I.. -I./.. 
> -DXMBINDDIR_FALLBACK=\"/usr/share/X11/bindings\" 
> -DINCDIR=\"/usr/include/X11\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu/X11\" 
> -DX11RGBPATH=\"/etc/X11/rgb.txt\" -Wdate-time -D_FORTIFY_SOURCE=2 
> -I/usr/include/freetype2 -I/usr/include/libpng16 -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FILE_OFFSET_BITS=64 -Wall -g 
> -fno-strict-aliasing -Wno-unused -Wno-comment -I/usr/include/freetype2 
> -I/usr/include/libpng16 -c Xpmparse.c  -fPIC -DPIC -o .libs/Xpmparse.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../include -I.. -I./.. 
> -DXMBINDDIR_FALLBACK=\"/usr/share/X11/bindings\" 
> -DINCDIR=\"/usr/include/X11\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu/X11\" 
> -DX11RGBPATH=\"/etc/X11/rgb.txt\" -Wdate-time -D_FORTIFY_SOURCE=2 
> -I/usr/include/freetype2 -I/usr/include/libpng16 -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FILE_OFFSET_BITS=64 -Wall -g 
> -fno-strict-aliasing -Wno-unused -Wno-comment -I/usr/include/freetype2 
> -I/usr/include/libpng16 -c XpmCrIFrP.c -o XpmCrIFrP.o >/dev/null 2>&1
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../include -I.. -I./.. 
> -DXMBINDDIR_FALLBACK=\"/usr/share/X11/bindings\" 
> -DINCDIR=\"/usr/include/X11\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu/X11\" 
> -DX11RGBPATH=\"/etc/X11/rgb.txt\" -Wdate-time -D_FORTIFY_SOURCE=2 
> -I/usr/include/freetype2 -I/usr/include/libpng16 -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FILE_OFFSET_BITS=64 -Wall -g 
> -fno-strict-aliasing -Wno-unused -Wno-comment -I/usr/include/freetype2 
> -I/usr/include/libpng16 -c XpmCrBufFrP.c  -fPIC -DPIC -o .libs/XpmCrBufFrP.o
> XpmWrFFrI.c: In function ‘XmeXpmWriteFileFromXpmImage’:
> XpmWrFFrI.c:122:13: error: implicit declaration of function ‘strncpy’ 
> [-Werror=implicit-function-declaration]
>   122 |             strncpy(new_name, name, sizeof(new_name));
>       |             ^~~~~~~
> XpmWrFFrI.c:44:1: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
>    43 | #include "XpmI.h"
>   +++ |+#include <string.h>
>    44 | #if !defined(NO_ZPIPE) && defined(WIN32)
> XpmWrFFrI.c:122:13: warning: incompatible implicit declaration of built-in 
> function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
>   122 |             strncpy(new_name, name, sizeof(new_name));
>       |             ^~~~~~~
> XpmWrFFrI.c:122:13: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
> XpmWrFFrI.c:133:17: warning: incompatible implicit declaration of built-in 
> function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
>   133 |                 strncpy(new_name, name, sizeof(new_name));
>       |                 ^~~~~~~
> XpmWrFFrI.c:133:17: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
> XpmWrFFrI.c: In function ‘WritePixels’:
> XpmWrFFrI.c:261:13: warning: incompatible implicit declaration of built-in 
> function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
>   261 |             strncpy(s, colors[*pixels].string, cpp);
>       |             ^~~~~~~
> XpmWrFFrI.c:261:13: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
> XpmWrFFrI.c:271:9: warning: incompatible implicit declaration of built-in 
> function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
>   271 |         strncpy(s, colors[*pixels].string, cpp);
>       |         ^~~~~~~
> XpmWrFFrI.c:271:9: note: include ‘<string.h>’ or provide a declaration of 
> ‘strncpy’
> XpmWrFFrI.c: In function ‘OpenWriteFile’:
> XpmWrFFrI.c:323:22: error: implicit declaration of function ‘strlen’ 
> [-Werror=implicit-function-declaration]
>   323 |         size_t len = strlen(filename);
>       |                      ^~~~~~
> XpmWrFFrI.c:323:22: note: include ‘<string.h>’ or provide a declaration of 
> ‘strlen’
> XpmWrFFrI.c:323:22: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
> XpmWrFFrI.c:323:22: note: include ‘<string.h>’ or provide a declaration of 
> ‘strlen’
> XpmWrFFrI.c:328:25: error: implicit declaration of function ‘strcmp’ 
> [-Werror=implicit-function-declaration]
>   328 |         if (len > 2 && !strcmp(".Z", filename + (len - 2))) {
>       |                         ^~~~~~
> XpmWrFFrI.c:328:25: note: include ‘<string.h>’ or provide a declaration of 
> ‘strcmp’
> In file included from Xpmparse.c:49:
> Xpmparse.c: In function ‘_XmxpmParseColors’:
> XpmI.h:304:26: warning: cast to pointer from integer of different size 
> [-Wint-to-pointer-cast]
>   304 | #define HashAtomData(i) ((void *)i)
>       |                          ^
> Xpmparse.c:390:61: note: in expansion of macro ‘HashAtomData’
>   390 |                     xpmHashIntern(hashtable, color->string, 
> HashAtomData(a));
>       |                                                             
> ^~~~~~~~~~~~
> XpmI.h:304:26: warning: cast to pointer from integer of different size 
> [-Wint-to-pointer-cast]
>   304 | #define HashAtomData(i) ((void *)i)
>       |                          ^
> Xpmparse.c:478:61: note: in expansion of macro ‘HashAtomData’
>   478 |                     xpmHashIntern(hashtable, color->string, 
> HashAtomData(a));
>       |                                                             
> ^~~~~~~~~~~~
> Xpmparse.c: In function ‘ParsePixels’:
> XpmI.h:305:31: warning: cast from pointer to integer of different size 
> [-Wpointer-to-int-cast]
>   305 | #define HashColorIndex(slot) ((unsigned int)((*slot)->data))
>       |                               ^
> Xpmparse.c:658:33: note: in expansion of macro ‘HashColorIndex’
>   658 |                         *iptr = HashColorIndex(slot);
>       |                                 ^~~~~~~~~~~~~~
> Obso1_2.c: In function ‘_XmCharsetCanonicalize’:
> Obso1_2.c:1868:7: warning: ‘__builtin_strncpy’ output truncated before 
> terminating nul copying as many bytes from a string as its length 
> [-Wstringop-truncation]
>  1868 |       strncpy(new_s, charset, len);
>       |       ^
> In function ‘_isISO’,
>     inlined from ‘_XmCharsetCanonicalize’ at Obso1_2.c:1853:12:
> Obso1_2.c:1826:7: note: length computed here
>  1826 |   if (strlen(charset) == 5)
>       |       ^~~~~~~~~~~~~~~
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../include -I.. -I./.. 
> -DXMBINDDIR_FALLBACK=\"/usr/share/X11/bindings\" 
> -DINCDIR=\"/usr/include/X11\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu/X11\" 
> -DX11RGBPATH=\"/etc/X11/rgb.txt\" -Wdate-time -D_FORTIFY_SOURCE=2 
> -I/usr/include/freetype2 -I/usr/include/libpng16 -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FILE_OFFSET_BITS=64 -Wall -g 
> -fno-strict-aliasing -Wno-unused -Wno-comment -I/usr/include/freetype2 
> -I/usr/include/libpng16 -c XpmRdFToBuf.c -o XpmRdFToBuf.o >/dev/null 2>&1
> /bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. 
> -I../../include -I.. -I./.. -DXMBINDDIR_FALLBACK=\"/usr/share/X11/bindings\" 
> -DINCDIR=\"/usr/include/X11\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu/X11\" 
> -DX11RGBPATH=\"/etc/X11/rgb.txt\"   -Wdate-time -D_FORTIFY_SOURCE=2  
> -I/usr/include/freetype2 -I/usr/include/libpng16   -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FILE_OFFSET_BITS=64 -Wall -g 
> -fno-strict-aliasing -Wno-unused -Wno-comment -I/usr/include/freetype2 
> -I/usr/include/libpng16    -c -o XpmCrPFrBuf.lo XpmCrPFrBuf.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../include -I.. -I./.. 
> -DXMBINDDIR_FALLBACK=\"/usr/share/X11/bindings\" 
> -DINCDIR=\"/usr/include/X11\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu/X11\" 
> -DX11RGBPATH=\"/etc/X11/rgb.txt\" -Wdate-time -D_FORTIFY_SOURCE=2 
> -I/usr/include/freetype2 -I/usr/include/libpng16 -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FILE_OFFSET_BITS=64 -Wall -g 
> -fno-strict-aliasing -Wno-unused -Wno-comment -I/usr/include/freetype2 
> -I/usr/include/libpng16 -c XpmCrBufFrP.c -o XpmCrBufFrP.o >/dev/null 2>&1
> cc1: some warnings being treated as errors
> make[4]: *** [Makefile:1182: XpmCrBufFrI.lo] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/motif_2.3.8-3_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Reply via email to