Package: fwbuilder
Version: 5.3.7-5+b2
Severity: normal
Tags: patch
Dear Maintainer,
fwbuilder crashes when trying to create almost any type of new object
To reproduce:
* start fwbuilder without any arguments
* click "New Object"
* click "New Library"
* fwbuilder will crash
The attached debdiff with upstream commit will fix the problem.
--
Regards
Sudip
-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.6.13-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages fwbuilder depends on:
ii fwbuilder-common 5.3.7-5
ii libc6 2.37-15
ii libgcc-s1 14-20240201-3
ii libqt5core5t64 5.15.10+dfsg-7.2+b1
ii libqt5gui5t64 5.15.10+dfsg-7.2+b1
ii libqt5network5t64 5.15.10+dfsg-7.2+b1
ii libqt5printsupport5t64 5.15.10+dfsg-7.2+b1
ii libqt5widgets5t64 5.15.10+dfsg-7.2+b1
ii libsnmp40t64 5.9.4+dfsg-1.1+b1
ii libstdc++6 14-20240201-3
ii libxml2 2.9.14+dfsg-1.3+b2
ii libxslt1.1 1.1.35-1
ii zlib1g 1:1.3.dfsg-3+b1
Versions of packages fwbuilder recommends:
ii fwbuilder-doc 5.3.7-5
ii rcs 5.10.1-1
fwbuilder suggests no packages.
-- no debconf information
diff -Nru fwbuilder-5.3.7/debian/changelog fwbuilder-5.3.7/debian/changelog
--- fwbuilder-5.3.7/debian/changelog 2022-01-23 23:01:26.000000000 +0000
+++ fwbuilder-5.3.7/debian/changelog 2024-04-11 23:04:28.000000000 +0100
@@ -1,3 +1,10 @@
+fwbuilder (5.3.7-5.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Add upstream commit to fix crash creating new object.
+
+ -- Sudip Mukherjee <sudipm.mukher...@gmail.com> Thu, 11 Apr 2024 23:04:28
+0100
+
fwbuilder (5.3.7-5) unstable; urgency=medium
[ Lukas Mardian ]
diff -Nru
fwbuilder-5.3.7/debian/patches/0001-adding-fix-for-crash-if-you-create-some-new-objects-.patch
fwbuilder-5.3.7/debian/patches/0001-adding-fix-for-crash-if-you-create-some-new-objects-.patch
---
fwbuilder-5.3.7/debian/patches/0001-adding-fix-for-crash-if-you-create-some-new-objects-.patch
1970-01-01 01:00:00.000000000 +0100
+++
fwbuilder-5.3.7/debian/patches/0001-adding-fix-for-crash-if-you-create-some-new-objects-.patch
2024-04-11 23:04:28.000000000 +0100
@@ -0,0 +1,38 @@
+From 102d68c3917950c688c1a3ca9bee42c3ff24b57f Mon Sep 17 00:00:00 2001
+From: bluelineXY <m.schr...@web.de>
+Date: Thu, 22 Feb 2018 21:43:53 +0100
+Subject: [PATCH] adding fix for crash if you create some new objects type out
+ of the menu (e.g. ip addess)
+
+Origin: upstream,
https://github.com/fwbuilder/fwbuilder/commit/102d68c3917950c688c1a3ca9bee42c3ff24b57f
+Last-Update: 2024-04-11
+---
+ src/libgui/ObjectManipulator_tree_ops.cpp | 12 ++++++++----
+ 1 file changed, 8 insertions(+), 4 deletions(-)
+
+diff --git a/src/libgui/ObjectManipulator_tree_ops.cpp
b/src/libgui/ObjectManipulator_tree_ops.cpp
+index ec80537d5..b3327f375 100644
+--- a/src/libgui/ObjectManipulator_tree_ops.cpp
++++ b/src/libgui/ObjectManipulator_tree_ops.cpp
+@@ -774,10 +774,14 @@ void ObjectManipulator::moveItems(ObjectTreeViewItem
*dest,
+ const list<FWObject *> &items)
+ {
+ string folder;
+- if (dest->getUserFolderParent() != 0) {
+- folder = dest->getUserFolderName().toUtf8().constData();
+- } else {
+- folder = dest->getFWObject()->getStr("folder");
++
++ if(dest != NULL)
++ {
++ if (dest->getUserFolderParent() != 0) {
++ folder = dest->getUserFolderName().toUtf8().constData();
++ } else {
++ folder = dest->getFWObject()->getStr("folder");
++ }
+ }
+
+ FWCmdMacro *macro = new FWCmdMacro(tr("Move objects"));
+--
+2.39.2
+
diff -Nru fwbuilder-5.3.7/debian/patches/series
fwbuilder-5.3.7/debian/patches/series
--- fwbuilder-5.3.7/debian/patches/series 2022-01-20 13:09:55.000000000
+0000
+++ fwbuilder-5.3.7/debian/patches/series 2024-04-11 23:04:10.000000000
+0100
@@ -6,3 +6,4 @@
pkg-config_libxml2.patch
pkg-config_libxslt.patch
ed4db20ec6cabfaea9c36187b7ce40d9d93c6c79.patch
+0001-adding-fix-for-crash-if-you-create-some-new-objects-.patch
