On Fri, 12 Apr 2024, 19:00 Johannes Schauer Marin Rodrigues, < jo...@debian.org> wrote:
> Hi Francesco, > > Quoting Francesco Poli (wintermute) (2024-04-11 00:13:51) > > > > sbuild --dist unstable --purge-build=never --purge-deps=never > --chroot-mode=autopkgtest --autopkgtest-virt-server=qemu > --autopkgtest-virt-server-opt --overlay-dir=/dev/shm > --autopkgtest-virt-server-opt --qemu-architecture=x86_64 > --autopkgtest-virt-server-opt --ram-size=2048 --autopkgtest-virt-server-opt > --cpus=2 --autopkgtest-virt-server-opt --boot=efi > --autopkgtest-virt-server-opt > /home/$USER/.cache/sbuild/unstable-autopkgtest-amd64.img > --bd-uninstallable-explainer apt > > Error reading configuration: PIUPARTS binary 'piuparts' does not exist > or is not executable at /usr/share/perl5/Sbuild/Conf.pm line 76. > > > > > > However, I thought that setting $run_piuparts = 1 in ~/.sbuildrc caused > > piuparts to be run inside the virtual machine guest system, not on the > > host system! > > What made you think that? Is the error message above not clear enough? Do > you > think it should be improved to make things clearer? Do you have > suggestions for > a message that would've better explained that piuparts needs to be > installed on > the host system? > Adding a data point, i would also like the error message to be clearer - i know that once you understand how sbuild and piuparts work it becomes "obvious" that piuparts needs to be run from the host -- but this is not at all clear for new users: would be great if the documentation and errors could clearly distinguish between which things inside/outside the chroot This particular error message could be improved in at least 3 ways: 1. "Error reading configuration" -- suggests it couldnt parse the config file, which doesnt seem to be the case here (suggest either dropping this from the error message or saying more clearly what the issue is) 2. "PIUPARTS binary 'piuparts' does not exist or is not executable" not sure why the capitials and repetition? just say more directly what the issue is: eg : "Error: piuparts not found (it needs to be installed on the host)" 3. "at /usr/share/perl5/Sbuild/Conf.pm line 76." -- not sure this implementation detail is helpful for a user -- it makes it look a bug rather than a message for the user: could it be dropped from the error message or hidden behind a "debug"/"verbose" setting? thanks for working on sbuild, it's really great.
