Package: nghttp2-proxy
Version: 1.62.1-1
Severity: important
Tags: patch
User: [email protected]
Usertags: dep17m2

Hi,

src:nghttp2 contains a single aliased file, nghttpx.service, in a single
binary package, nghttp2-proxy. This file should be moved to /usr to
eliminate aliasing-caused bugs from Debian (DEP17). In this case, I
propose using dh_installsystemd as it is fully backports-compatible and
simplifies the packaging. I'm attaching a patch for your convenience.

Helmut
diff -Nru nghttp2-1.62.1/debian/changelog nghttp2-1.62.1/debian/changelog
--- nghttp2-1.62.1/debian/changelog     2024-05-18 09:28:10.000000000 +0200
+++ nghttp2-1.62.1/debian/changelog     2024-06-12 14:06:19.000000000 +0200
@@ -1,3 +1,10 @@
+nghttp2 (1.62.1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Install systemd unit using dh_installsystemd. (Closes: #-1)
+
+ -- Helmut Grohne <[email protected]>  Wed, 12 Jun 2024 14:06:19 +0200
+
 nghttp2 (1.62.1-1) unstable; urgency=medium
 
   * New upstream version 1.62.1
diff -Nru nghttp2-1.62.1/debian/nghttp2-proxy.nghttpx.service 
nghttp2-1.62.1/debian/nghttp2-proxy.nghttpx.service
--- nghttp2-1.62.1/debian/nghttp2-proxy.nghttpx.service 1970-01-01 
01:00:00.000000000 +0100
+++ nghttp2-1.62.1/debian/nghttp2-proxy.nghttpx.service 2024-05-18 
09:28:10.000000000 +0200
@@ -0,0 +1,17 @@
+[Unit]
+Description=HTTP/2 proxy
+Documentation=man:nghttpx
+After=network.target
+
+[Service]
+Type=notify
+ExecStart=/usr/sbin/nghttpx --conf=/etc/nghttpx/nghttpx.conf
+ExecReload=/bin/kill --signal HUP $MAINPID
+KillSignal=SIGQUIT
+PrivateTmp=yes
+ProtectHome=yes
+ProtectSystem=full
+Restart=always
+
+[Install]
+WantedBy=multi-user.target
diff -Nru nghttp2-1.62.1/debian/nghttpx.service 
nghttp2-1.62.1/debian/nghttpx.service
--- nghttp2-1.62.1/debian/nghttpx.service       2024-05-18 09:28:10.000000000 
+0200
+++ nghttp2-1.62.1/debian/nghttpx.service       1970-01-01 01:00:00.000000000 
+0100
@@ -1,17 +0,0 @@
-[Unit]
-Description=HTTP/2 proxy
-Documentation=man:nghttpx
-After=network.target
-
-[Service]
-Type=notify
-ExecStart=/usr/sbin/nghttpx --conf=/etc/nghttpx/nghttpx.conf
-ExecReload=/bin/kill --signal HUP $MAINPID
-KillSignal=SIGQUIT
-PrivateTmp=yes
-ProtectHome=yes
-ProtectSystem=full
-Restart=always
-
-[Install]
-WantedBy=multi-user.target
diff -Nru nghttp2-1.62.1/debian/rules nghttp2-1.62.1/debian/rules
--- nghttp2-1.62.1/debian/rules 2024-05-18 09:28:10.000000000 +0200
+++ nghttp2-1.62.1/debian/rules 2024-06-12 14:06:00.000000000 +0200
@@ -55,10 +55,8 @@
 
 # Currently we install our own systemd unit because
 # the original one is slightly broken
-SYSTEMD="debian/nghttp2-proxy/lib/systemd/system"
 custom_install_systemd:
-       install -d $(SYSTEMD)
-       install -p -m644 debian/nghttpx.service $(SYSTEMD)/nghttpx.service
+       dh_installsystemd -pnghttp2-proxy --name nghttpx
 
 %:
        dh $@

Reply via email to