Don,

On Wednesday, September 25, 2024 9:59:25 PM MST Don Armstrong wrote:
> I've got the patch for it, I think it just needs a new release to
> include it.

Thanks for doing this, but I think your patch is based on an older attempt to 
implement this.  Based on the consensus discussion [1] the following things 
should be adjusted.

1.  The .bdic should be placed in /usr/share/hunspell-bdic/ instead of /usr/
share/hunspell/.

2.  There is no need to place symlinks in /usr/share/qt5/
qtwebengine_dictionaries/ or /usr/share/qt6/qtwebengine_dictionaries/.

3.  You should build-depend on the virtual package convert-bdic instead of 
qtwebengine5-dev-tools and libqt5webengine-data.  convert-bdic is a virtual 
package that will always be provided by the newest qtwebengine in Debian.  
This eases the Qt 5 to Qt 6 and future transitions.

4.  When depending on convert-bdic, you should call /usr/bin/convert-bdic 
instead of /usr/bin/convert-bdic/usr/lib/qt5/bin/qwebengine_convert_dict.

5.  The .bdic files need to be deleted from the source at the end of the build 
or reproducible builds will fail.  You can do this using debian/clean or any 
other method of your choice.

I am happy to prepare a patch that accomplished this if you like, although you 
can probably do it as fast as I can.  :)

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020387
-- 
Soren Stoutner
[email protected]

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to