Control: tags -1 pending
Niels Thykier writes ("Bug#1086628: authbind: Support root-less builds"):
...
> * Patch 0002 adds Vcs headers. I considered adding a `Homepage` but
> I could not find a good dedicated `Homepage` link for specifically
> for the tool. This patch is optional.
> Additionally, I have attached a debdiff and a diffoscope diff of
> authbind build before and after the changes. Note the "before" was done
> in a clean up-to-date sid chroot (rather than using the in-archive
> version of authbind). This was to reduce the noise from different
> compiler versions.
Thanks. This was particularly helpful because right now I can't
easily install diffoscope (hazards of running trixie I guess; filed
#1087296).
Thank you also for the thorough analysis of the resulting changes,
which was also very helpful.
> There is one outstanding TODO for the upstream side about
> libauthbind.so.1.0 not having a build-id, which causes its debug symbols
> to be omitted from the dbgsym. I think it could be solvable by having
> $(CC) do the linking as well. However, it is not my strongest suit and
> it was not mandatory to solve the problem I had (which was root-less
> builds). Accordingly, I have left it as-is (there is still a dbgsym
> package with debug symbols for other ELF binaries).
Right. FTR, with my upstream hat on I would welcome a patch for this
from someone who feels like they knew what they are doing :-).
> I provided an optional patch for Vcs headers via 0002 based on the
> provided link and the `git://` link from that page. I did not have any
> luck cloning via the `https://` link provided, otherwise I would have
> used that.
>
> Side note: I think the Vcs-Git header triggers an "insecure-uri" tag
> from lintian. If you have a secure replacement for the `Vcs-Git` field,
> consider amending 0002 to use that instead.
I changed the Vcs-Git to
Vcs-Git: https://www.chiark.greenend.org.uk/ucgi/~ian/githttp/authbind.git
which worked with git-ls-remote and git-clone in my tests.
NB that the https:// for git is not the same as for browsing.
> Attached patches (via `git format-patch`) solves my issue and a few
> minor tweaks on top of that.
As I wrote a little while ago, your patches were (due an error of
mine) against an earlier version. After having looked at them and
seen what happens in the build, I have resolved the conflict by taking
your rules file. Thanks!
I'll do a bit of double checking but I expect to upload later tonight.
Regards,
Ian.
--
Ian Jackson <[email protected]> These opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
