Control: tags -1 +moreinfo Bret,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue Running lintian... N: W: vulkanscenegraph source: build-depends-on-obsolete-package Build-Depends: pkg-config => pkgconf N: N: The package build-depends on a package that has been superseded. If the N: superseded package is part of an ORed group, it should not be the first N: package in the group. N: N: Visibility: warning N: Show-Always: no N: Check: fields/package-relations N: N: I: libvsg14: hardening-no-bindnow [usr/lib/x86_64-linux-gnu/libvsg.so.1.1.7] N: N: This package provides an ELF binary that lacks the "bindnow" linker flag. N: N: This is needed (together with "relro") to make the "Global Offset Table" N: (GOT) fully read-only. The bindnow feature trades startup time for N: improved security. Please consider enabling this feature or consider N: overriding the tag (possibly with a comment about why). N: N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or N: hardening=+all to DEB_BUILD_MAINT_OPTIONS. N: N: The relevant compiler flags are set in LDFLAGS. N: N: Please refer to https://wiki.debian.org/Hardening for details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: vulkanscenegraph source: quilt-patch-missing-description [debian/patches/001-glslang-min-version.patch] N: N: quilt patch files should start with a description of patch. All lines N: before the start of the patch itself are considered part of the N: description. You can edit the description with quilt header -e when the N: patch is at the top of the stack. N: N: As well as a description of the purpose and function of the patch, the N: description should ideally contain author information, a URL for the bug N: report (if any), Debian or upstream bugs fixed by it, upstream status, the N: Debian version and date the patch was first included, and any other N: information that would be useful if someone were investigating the patch N: and underlying problem. Please consider using the DEP 3 format for this N: information. N: N: Please refer to https://dep-team.pages.debian.net/deps/dep3/ for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/quilt N: N: I: libvsg14: spelling-error-in-binary enought enough [usr/lib/x86_64-linux- gnu/libvsg.so.1.1.7] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling N: N: I: libvsg14: symbols-file-missing-build-depends-package-field libvsg.so.14 [symbols] N: N: The symbols file for this package does not contain a Build-Depends- Package N: meta-information field. N: N: This field specifies the name of the -dev package associated to the N: library and is used by dpkg-shlibdeps(1) to make sure that the dependency N: generated is at least as strict as the corresponding build dependency. N: N: This is useful as allows packages to not hardcode this information N: multiple times. N: N: Note that the format of deb-symbols(5) files requires that the * N: Build-Depends-Package: line should start in column one of the file and not N: be indented to align with the symbols themselves. Please do not use the N: placeholder #PACKAGE#. The development package for your shared library N: must be stated explicitly. N: N: Please refer to The symbols File Format (Section 8.6.3.2) in the Debian N: Policy Manual, the deb-symbols(5) manual page, the dpkg-shlibdeps(1) N: manual page, N: https://www.debian.org/doc/manuals/maint-guide/advanced.en.html#librarysymbols , N: and Bug#944047 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/shlibs N: I: Lintian run was successful. 3. Licenses [4]: Information You may wish to license as MIT as the files are licensed. This will quieten 'lrc'. 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: N/A Additional... A. Package is not yet in debian. Changelog should be like below. vulkanscenegraph (1.1.7-1) unstable; urgency=low . * Initial release. (Closes: #<ITP_BUG_NUMBER>) Summary... This is good work/initial packaging, just a few things to clean up. I believe vulkanscenegraph is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
