tags 369709 + patch thanks Martin Michlmayr <[EMAIL PROTECTED]> writes:
> I thought this was supposed to be fixed in the new version (sorry,
> cannot check right now since bugs.d.o is down):
It was supposed to be fixed, but I missed something while fixing it.
> 22723:[EMAIL PROTECTED]: ~/debian/build] /usr/share/sbuild/checkchroot
> unstable
> ...
> e2fsprogs
> ed
> findutils
> foo
> Use of uninitialized value in string comparison (cmp) at
> /usr/share/sbuild/checkchroot line 89.
> Use of uninitialized value in concatenation (.) or string at
> /usr/share/sbuild/checkchroot line 96.
>
> Use of uninitialized value in string comparison (cmp) at
> /usr/share/sbuild/checkchroot line 89.
Please could you try the attached patch, and let me know if it fixes
the problem?
Thanks,
Roger
--
Roger Leigh
Printing on GNU/Linux? http://gutenprint.sourceforge.net/
Debian GNU/Linux http://www.debian.org/
GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
Index: bin/checkchroot
===================================================================
--- bin/checkchroot (revision 705)
+++ bin/checkchroot (working copy)
@@ -84,7 +84,7 @@
my $i = 0;
my $j = 0;
-while ($i < scalar @status || $j < scalar @ref) {
+while ($i < scalar @status && $j < scalar @ref) {
my $c = $status[$i] cmp $ref[$j];
if ($c < 0) {
@@ -101,7 +101,16 @@
}
}
-#ystem ("diff -u '$F1' '$F2' | tail -n +3 | grep ^[+-] | sed -e 's/^-//' -e 's/^+/ /' | sort");
+# Print any remaining elements
+while ($i < scalar @status) {
+ print "$status[$i]\n";
+ $i++;
+}
+while ($j < scalar @ref) {
+ print " $ref[$j]\n";
+ $j++;
+}
+
cleanup();
exit 0;
pgpoV8D8g7JAD.pgp
Description: PGP signature

