Bug#1089469: wp2x: Supporting rootless builds by default

Sat, 07 Dec 2024 13:06:19 -0800 

Source: wp2x
Version: 2.5-mhi-14
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
wp2x failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
      |                       ~~~~~~~~~~~~~~~~^~~
tokens.c:31:50: warning: unused parameter ‘data’ [-Wunused-parameter]
   31 | softPage (state * st, struct WPToken *wpt, void *data)
      |                                            ~~~~~~^~~~
tokens.c: In function ‘ignoreByte’:
tokens.c:45:21: warning: unused parameter ‘st’ [-Wunused-parameter]
   45 | ignoreByte (state * st, struct WPToken *wpt, void *data)
      |             ~~~~~~~~^~
tokens.c:45:52: warning: unused parameter ‘data’ [-Wunused-parameter]
   45 | ignoreByte (state * st, struct WPToken *wpt, void *data)
      |                                              ~~~~~~^~~~
tokens.c: In function ‘ignoreFixed’:
tokens.c:55:22: warning: unused parameter ‘st’ [-Wunused-parameter]
   55 | ignoreFixed (state * st, struct WPToken *wpt, void *data)
      |              ~~~~~~~~^~
tokens.c:55:53: warning: unused parameter ‘data’ [-Wunused-parameter]
   55 | ignoreFixed (state * st, struct WPToken *wpt, void *data)
      |                                               ~~~~~~^~~~
tokens.c: In function ‘ignoreVar’:
tokens.c:65:20: warning: unused parameter ‘st’ [-Wunused-parameter]
   65 | ignoreVar (state * st, struct WPToken *wpt, void *data)
      |            ~~~~~~~~^~
tokens.c:65:40: warning: unused parameter ‘wpt’ [-Wunused-parameter]
   65 | ignoreVar (state * st, struct WPToken *wpt, void *data)
      |                        ~~~~~~~~~~~~~~~~^~~
tokens.c: In function ‘hardPage’:
tokens.c:77:39: warning: unused parameter ‘wpt’ [-Wunused-parameter]
   77 | hardPage (state * st, struct WPToken *wpt, void *data)
      |                       ~~~~~~~~~~~~~~~~^~~
tokens.c:77:50: warning: unused parameter ‘data’ [-Wunused-parameter]
   77 | hardPage (state * st, struct WPToken *wpt, void *data)
      |                                            ~~~~~~^~~~
tokens.c: In function ‘softReturn’:
tokens.c:84:41: warning: unused parameter ‘wpt’ [-Wunused-parameter]
   84 | softReturn (state * st, struct WPToken *wpt, void *data)
      |                         ~~~~~~~~~~~~~~~~^~~
tokens.c:84:52: warning: unused parameter ‘data’ [-Wunused-parameter]
   84 | softReturn (state * st, struct WPToken *wpt, void *data)
      |                                              ~~~~~~^~~~
tokens.c: In function ‘outputToken’:
tokens.c:91:53: warning: unused parameter ‘data’ [-Wunused-parameter]
   91 | outputToken (state * st, struct WPToken *wpt, void *data)
      |                                               ~~~~~~^~~~
tokens.c: In function ‘extendedChar’:
tokens.c:98:43: warning: unused parameter ‘wpt’ [-Wunused-parameter]
   98 | extendedChar (state * st, struct WPToken *wpt, void *data)
      |                           ~~~~~~~~~~~~~~~~^~~
tokens.c: In function ‘attributeOn’:
tokens.c:113:42: warning: unused parameter ‘wpt’ [-Wunused-parameter]
  113 | attributeOn (state * st, struct WPToken *wpt, void *data)
      |                          ~~~~~~~~~~~~~~~~^~~
tokens.c: In function ‘attributeOff’:
tokens.c:174:43: warning: unused parameter ‘wpt’ [-Wunused-parameter]
  174 | attributeOff (state * st, struct WPToken *wpt, void *data)
      |                           ~~~~~~~~~~~~~~~~^~~
tokens.c: In function ‘endIndent’:
tokens.c:235:20: warning: unused parameter ‘st’ [-Wunused-parameter]
  235 | endIndent (state * st, struct WPToken *wpt, void *data)
      |            ~~~~~~~~^~
tokens.c:235:40: warning: unused parameter ‘wpt’ [-Wunused-parameter]
  235 | endIndent (state * st, struct WPToken *wpt, void *data)
      |                        ~~~~~~~~~~~~~~~~^~~
tokens.c:235:51: warning: unused parameter ‘data’ [-Wunused-parameter]
  235 | endIndent (state * st, struct WPToken *wpt, void *data)
      |                                             ~~~~~~^~~~
tokens.c: In function ‘startIndent’:
tokens.c:242:42: warning: unused parameter ‘wpt’ [-Wunused-parameter]
  242 | startIndent (state * st, struct WPToken *wpt, void *data)
      |                          ~~~~~~~~~~~~~~~~^~~
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wdate-time -D_FORTIFY_SOURCE=2 -g -O -ansi -funsigned-char -W -Wall -DUNIX -DWP2X_DIR=\"/usr/share/wp2x\" -DVERSION=\"2.5\" -c -o charsets.o charsets.c gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wdate-time -D_FORTIFY_SOURCE=2 -g -O -ansi -funsigned-char -W -Wall -DUNIX -DWP2X_DIR=\"/usr/share/wp2x\" -DVERSION=\"2.5\" -c -o getopt.o getopt.c gcc -o wp2x -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wdate-time -D_FORTIFY_SOURCE=2 -g -O -ansi -funsigned-char -W -Wall -DUNIX -DWP2X_DIR=\"/usr/share/wp2x\" -DVERSION=\"2.5\" -Wl,-z,relro -Wl,-z,now -Wl,--as-needed wp2x.o dopen.o tokens.o charsets.o getopt.o 
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
        make -j8 test
make[1]: Entering directory '/<<PKGBUILDDIR>>'
cd src && make wp2x WP2X_DIR=/usr/share/wp2x VERSION=2.5
make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
make[2]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. 
make[2]: 'wp2x' is up to date.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
cd test && make test
make[2]: Entering directory '/<<PKGBUILDDIR>>/test'
make[2]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. 
Starting regression tests.
INPUTS='simple-iso.wp wp.wp' CFGFILES='accent.cfg ascii.cfg gml.cfg html.cfg latex.cfg sample.cfg script.cfg tex.cfg troff.cfg' WP2X=../src/wp2x sh do-regress 
Testing input: simple-iso.wp with cfg: accent.cfg  -> passed
Testing input: simple-iso.wp with cfg: ascii.cfg  -> passed
Testing input: simple-iso.wp with cfg: gml.cfg  -> passed
Testing input: simple-iso.wp with cfg: html.cfg  -> passed
Testing input: simple-iso.wp with cfg: latex.cfg  -> passed
Testing input: simple-iso.wp with cfg: sample.cfg  -> passed
Testing input: simple-iso.wp with cfg: script.cfg  -> passed
Testing input: simple-iso.wp with cfg: tex.cfg  -> passed
Testing input: simple-iso.wp with cfg: troff.cfg  -> passed
Testing input: wp.wp with cfg: accent.cfg  -> passed
Testing input: wp.wp with cfg: ascii.cfg  -> passed
Testing input: wp.wp with cfg: gml.cfg  -> passed
Testing input: wp.wp with cfg: html.cfg  -> passed
Testing input: wp.wp with cfg: latex.cfg  -> passed
Testing input: wp.wp with cfg: sample.cfg  -> passed
Testing input: wp.wp with cfg: script.cfg  -> passed
Testing input: wp.wp with cfg: tex.cfg  -> passed
Testing input: wp.wp with cfg: troff.cfg  -> passed
make[2]: Leaving directory '/<<PKGBUILDDIR>>/test'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_installdirs
   dh_auto_install --destdir=debian/wp2x/
make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/wp2x AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" 
make[1]: Entering directory '/<<PKGBUILDDIR>>'
mkdir -p /<<PKGBUILDDIR>>/debian/wp2x/usr/bin
mkdir -p /<<PKGBUILDDIR>>/debian/wp2x/usr/share/man/man1
mkdir -p /<<PKGBUILDDIR>>/debian/wp2x/usr/share/wp2x
make -C src install BINDIR=/<<PKGBUILDDIR>>/debian/wp2x/usr/bin \
        WP2X_DIR=/<<PKGBUILDDIR>>/debian/wp2x/usr/share/wp2x
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. 
install -c -o root -g root -m 755 wp2x /<<PKGBUILDDIR>>/debian/wp2x/usr/bin
install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/wp2x/usr/bin/wp2x': Operation not permitted 
make[2]: *** [Makefile:13: install] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[1]: *** [Makefile:21: install] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_install: error: make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/wp2x AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" returned exit code 2 
make: *** [debian/rules:17: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 
--------------------------------------------------------------------------------
Build finished at 2024-11-18T20:31:19Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1051208.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to