Bug#1089477: xiterm+thai: Supporting rootless builds by default

Niels Thykier Sat, 07 Dec 2024 13:09:35 -0800

Source: xiterm+thai
Version: 1.10-2
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: rrr-no-as-default-issue


Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
xiterm+thai failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
checking for fcntl.h... yes
checking for termios.h... yes
checking for sys/ioctl.h... yes
checking for sys/select.h... yes
checking for sys/time.h... (cached) yes
checking for sys/sockio.h... no
checking for sys/byteorder.h... no
checking for utmpx.h... yes
checking for unistd.h... (cached) yes
checking for mode_t... yes
checking for pid_t... yes
checking for uid_t... yes
checking for gid_t... yes
checking return type of signal handlers... void
checking for atexit... yes
checking for unsetenv... yes
checking for setutent... yes
checking for seteuid... yes
configure: creating ./config.status
config.status: creating Make.common

config.status: WARNING: 'Make.common.in' seems to ignore the --datarootdir setting

config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating data/Makefile
config.status: creating doc/Makefile
config.status: creating doc/LSM
config.status: creating doc/xiterm+thai.1
config.status: creating config.h

Configuration:

  Source code location:       .
  Compiler:                   gcc

Compiler flags: -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard

  Install path:               /usr/bin

dh_testdir
# Add here commands to compile the package.
/usr/bin/make
make[1]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
echo "#define VERSION \""1.10"\"" > VERSION.h;

command.c: In function ‘privileges’:

command.c:439:7: warning: ignoring return value of ‘seteuid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  439 |       seteuid (getuid ());
      |       ^~~~~~~~~~~~~~~~~~~

command.c:440:7: warning: ignoring return value of ‘setegid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  440 |       setegid (getgid ());
      |       ^~~~~~~~~~~~~~~~~~~

command.c:449:7: warning: ignoring return value of ‘seteuid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  449 |       seteuid (euid);
      |       ^~~~~~~~~~~~~~

command.c:450:7: warning: ignoring return value of ‘setegid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  450 |       setegid (egid);
      |       ^~~~~~~~~~~~~~

main.c: In function ‘scale_pixmap’:

main.c:293:24: warning: ‘%d’ directive writing between 1 and 6 bytes into a region of size between 5 and 15 [-Wformat-overflow=]

  293 |                "[%dx%d+%d+%d]",
      |                        ^~
main.c:293:16: note: directive argument in the range [-32768, 32767]
  293 |                "[%dx%d+%d+%d]",
      |                ^~~~~~~~~~~~~~~
main.c:293:16: note: directive argument in the range [-32768, 32767]
In file included from /usr/include/stdio.h:970,
                 from main.h:32,
                 from main.c:24:
In function ‘sprintf’,
    inlined from ‘scale_pixmap’ at main.c:292:7:

/usr/include/aarch64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 10 and 30 bytes into a destination of size 20

   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~

gcc -c -Wdate-time -D_FORTIFY_SOURCE=2 -I./.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard misc.c gcc -c -Wdate-time -D_FORTIFY_SOURCE=2 -I./.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard netdisp.c gcc -c -Wdate-time -D_FORTIFY_SOURCE=2 -I./.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard screen.c gcc -c -Wdate-time -D_FORTIFY_SOURCE=2 -I./.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard scrollbar.c gcc -c -Wdate-time -D_FORTIFY_SOURCE=2 -I./.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard utmp.c gcc -c -Wdate-time -D_FORTIFY_SOURCE=2 -I./.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard xdefaults.c gcc -c -Wdate-time -D_FORTIFY_SOURCE=2 -I./.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard thai.c gcc -c -Wdate-time -D_FORTIFY_SOURCE=2 -I./.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard thaikb.c gcc -Wl,-z,relro -Wl,-z,now -o xiterm+thai command.o debug.o graphics.o grkelot.o main.o misc.o netdisp.o screen.o scrollbar.o utmp.o xdefaults.o thai.o thaikb.o -lXpm -lX11 make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'

make[2]: Entering directory '/<<PKGBUILDDIR>>/data'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/data'
make[2]: Entering directory '/<<PKGBUILDDIR>>/doc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
touch build-stamp
dh_testdir
dh_testroot
dh_prep
dh_installdirs

dh_installdirs: warning: Compatibility levels before 10 are deprecated (level 7 in use)

# Add here commands to install the package into debian/xiterm+thai.
/usr/bin/make install DESTDIR=/<<PKGBUILDDIR>>/debian/xiterm+thai
make[1]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: Entering directory '/<<PKGBUILDDIR>>/src'

/usr/bin/install -c -D -m 755 xiterm+thai /<<PKGBUILDDIR>>/debian/xiterm+thai/usr/bin/xiterm+thai

make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: Entering directory '/<<PKGBUILDDIR>>/data'

/usr/bin/install -c -D -m 644 xiterm+thai.png /<<PKGBUILDDIR>>/debian/xiterm+thai/usr/share/pixmaps/xiterm+thai.png

make[2]: Leaving directory '/<<PKGBUILDDIR>>/data'
make[2]: Entering directory '/<<PKGBUILDDIR>>/doc'
/usr/bin/install -c -D -m 644 xiterm+thai.1 \
  /<<PKGBUILDDIR>>/debian/xiterm+thai/usr/share/man/man1/xiterm+thai.1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'

install -D -m 0755 -o root -g root debian/txiterm debian/xiterm+thai/usr/bin/txiterm install: cannot change ownership of 'debian/xiterm+thai/usr/bin/txiterm': Operation not permitted

make: *** [debian/rules:66: install] Error 1

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

--------------------------------------------------------------------------------
Build finished at 2024-11-18T21:06:55Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1052112.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089477: xiterm+thai: Supporting rootless builds by default

Reply via email to