On Mon, Jun 12, 2006 at 02:09:40PM +0200, Loïc Minier wrote:
>  Attached patch adds recommended support for noopt and nostrip
>  DEB_BUILD_OPTIONS which makes getting backtraces from submitters with
>  debugging symbols more useful.

Thanks for the patch!

> +ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
> +        INSTALL_PROGRAM += -s
> +endif

This looks superfluous to me as dh_strip should already handle nostrip
internally.

> -     ./configure --prefix=/usr --mandir=\$${prefix}/share/man 
> --infodir=\$${prefix}/share/info
> +     env CFLAGS="$(CFLAGS)" ./configure --prefix=/usr 
> --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info

Why are you using env here? CFLAGS="$(CFLAGS)" ./configure ... ought to
suffice from what I can tell.

Regards,

Daniel.


Reply via email to