Bug#1089457: tua: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:56:26 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: tua
Version: 4.3-16
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
tua failed to rebuild.

[...]

Hi,

Please see attached as a patch.





Best regards,
Niels


diff -u tua-4.3/debian/changelog tua-4.3/debian/changelog
--- tua-4.3/debian/changelog
+++ tua-4.3/debian/changelog
@@ -1,3 +1,11 @@
+tua (4.3-16.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089457)
+
+ -- Niels Thykier <ni...@thykier.net>  Mon, 30 Dec 2024 18:52:29 +0000
+
 tua (4.3-16) unstable; urgency=low
 
   * Work around GCC breakage (closes: #1075587).
diff -u tua-4.3/debian/control tua-4.3/debian/control
--- tua-4.3/debian/control
+++ tua-4.3/debian/control
@@ -3,6 +3,7 @@
 Priority: extra
 Maintainer: Mark Brown <broo...@debian.org>
 Build-Depends: bison, gettext, texinfo, debhelper (>= 9), dpkg-dev (>= 1.16.1)
+Rules-Requires-Root: no
 Standards-Version: 3.9.4
 
 Package: tua
diff -u tua-4.3/debian/rules tua-4.3/debian/rules
--- tua-4.3/debian/rules
+++ tua-4.3/debian/rules
@@ -28,7 +28,7 @@
        echo TUA produces no arch all packages.
 
 # Build architecture-dependent files here.
-binary-arch: checkroot build
+binary-arch: build
        $(checkdir)
        -rm -rf debian/tua
 
@@ -56,7 +56,4 @@
 
 binary: binary-arch
 
-checkroot:
-       test root = "`whoami`"
-
-.PHONY: binary binary-arch binary-indep clean checkroot
+.PHONY: binary binary-arch binary-indep clean

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance. Note: I intend to include the patch in #939778 (cross-building support) as well if I perform a NMU unless there are compelling reason to omit it.

OpenPGP_signature.asc
Description: OpenPGP digital signature