Bug#1089466: wm-icons: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 22:03:07 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: wm-icons
Version: 0.4.0-11.1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
wm-icons failed to rebuild.

[...]

Hi

Please see attached as a patch.



Best regards,
Niels


diff -Nru wm-icons-0.4.0/debian/changelog wm-icons-0.4.0/debian/changelog
--- wm-icons-0.4.0/debian/changelog     2024-05-31 22:28:40.000000000 +0200
+++ wm-icons-0.4.0/debian/changelog     2024-12-31 11:21:28.000000000 +0100
@@ -1,3 +1,11 @@
+wm-icons (0.4.0-11.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089466)
+
+ -- Niels Thykier <ni...@thykier.net>  Tue, 31 Dec 2024 10:21:28 +0000
+
 wm-icons (0.4.0-11.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru wm-icons-0.4.0/debian/control wm-icons-0.4.0/debian/control
--- wm-icons-0.4.0/debian/control       2024-05-31 22:28:40.000000000 +0200
+++ wm-icons-0.4.0/debian/control       2024-12-31 11:21:23.000000000 +0100
@@ -2,6 +2,7 @@
 Vcs-Git: https://salsa.debian.org/srivasta/wm-icons.git
 Vcs-Browser: https://salsa.debian.org/srivasta/wm-icons
 Section: misc
+Rules-Requires-Root: no
 Standards-Version: 4.3.0
 Maintainer: Manoj Srivastava <sriva...@debian.org>
 Priority: optional
diff -Nru wm-icons-0.4.0/debian/rules wm-icons-0.4.0/debian/rules
--- wm-icons-0.4.0/debian/rules 2024-05-31 22:28:04.000000000 +0200
+++ wm-icons-0.4.0/debian/rules 2024-12-31 11:21:12.000000000 +0100
@@ -8,10 +8,10 @@
 ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS)))
     INSTALL_PROGRAM += -s
 endif
-install_file    = $(INSTALL) -p    -o root -g root  -m  644
-install_program = $(INSTALL) -p    -o root -g root  -m  755
-install_script  = $(INSTALL) -p    -o root -g root  -m  755
-make_directory  = $(INSTALL) -p -d -o root -g root  -m  755
+install_file    = $(INSTALL) -p    -m  644
+install_program = $(INSTALL) -p    -m  755
+install_script  = $(INSTALL) -p    -m  755
+make_directory  = $(INSTALL) -p -d -m  755
 package:=wm-icons
 METHODSDIR = $(TMPTOP)/etc/menu-methods
 METHODSLOC = $(TMPTOP)/etc/X11/fvwm/wm-icons

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature