Bug#1089473: xcolors: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 22:06:05 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: xcolors
Version: 1.5a-9
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
xcolors failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi


Please see attached as a patch.



Best regards,
Niels


diff -Nru xcolors-1.5a/debian/changelog xcolors-1.5a/debian/changelog
--- xcolors-1.5a/debian/changelog       2024-11-23 15:52:00.000000000 +0100
+++ xcolors-1.5a/debian/changelog       2024-12-31 12:29:06.000000000 +0100
@@ -1,3 +1,11 @@
+xcolors (1.5a-10.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089473)
+
+ -- Niels Thykier <ni...@thykier.net>  Tue, 31 Dec 2024 11:29:06 +0000
+
 xcolors (1.5a-10) unstable; urgency=medium
 
   * Fix gcc-14 build issues (closes: #1075653)
diff -Nru xcolors-1.5a/debian/control xcolors-1.5a/debian/control
--- xcolors-1.5a/debian/control 2024-03-16 13:25:23.000000000 +0100
+++ xcolors-1.5a/debian/control 2024-12-31 12:28:33.000000000 +0100
@@ -2,6 +2,7 @@
 Section: x11
 Priority: optional
 Maintainer: Fredrik Hallenberg <hal...@debian.org>
+Rules-Requires-Root: no
 Standards-Version: 3.9.4
 Build-Depends: debhelper-compat (= 13), libxaw7-dev, libxt-dev, libx11-dev, 
xutils-dev
 
diff -Nru xcolors-1.5a/debian/rules xcolors-1.5a/debian/rules
--- xcolors-1.5a/debian/rules   2013-07-30 23:16:56.000000000 +0200
+++ xcolors-1.5a/debian/rules   2024-12-31 12:29:00.000000000 +0100
@@ -40,13 +40,13 @@
        rm -rf *~ debian/xcolors debian/*~ debian/files*
        dh_clean
 
-binary-indep:  checkroot build
+binary-indep:  build
        $(checkdir)
 # There are no architecture-independent files to be uploaded
 # generated by this package.  If there were any they would be
 # made here.
 
-binary-arch:   checkroot build
+binary-arch:   build
        $(checkdir)
        -rm -rf debian/tmp
        test -f build || make -f debian/rules build
@@ -75,8 +75,4 @@
 source diff:
        @echo >&2 'source and diff are obsolete - use dpkg-source -b'; false
 
-checkroot:
-       $(checkdir)
-       test root = "`whoami`"
-
-.PHONY: binary binary-arch binary-indep clean checkroot
+.PHONY: binary binary-arch binary-indep clean

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature