Control: tags -1 patch On Sat, 7 Dec 2024 20:39:08 +0100 Niels Thykier <[email protected]> wrote:
Source: logtool Version: 1.2.8-13 Severity: important Tags: ftbfs Justification: FTBFS X-Debbugs-Cc: [email protected] User: [email protected] Usertags: rrr-no-as-default-issueDear maintainer, During a test rebuild for building packages with `Rules-Requires-Root: no` as the default in `dpkg`, logtool failed to rebuild. Log Summary: ------------------------------------------------------------------------------- [...]
Hi Please see attached as a patch.I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.
Note: If it comes to an NMU, then I will include the fix for #941462 (cross building) as well. If you do a maintainer upload, please consider applying that fix as well.
This package can probably come truly rootless if the upstream makefile could be convinced to not pass `-o root` to `install`. A common trick here is to use `-o $(USER)` and then have the Debian package substitute USER with `id -u` (which is a noop but allowed) and then rely on `dh_fixperms` + `dh_builddeb` to build the package with the correct ownership. However, it is was not a minimal patch, so I skipped that for the NMU.
Best regards, Niels
diff -u logtool-1.2.8/debian/changelog logtool-1.2.8/debian/changelog --- logtool-1.2.8/debian/changelog +++ logtool-1.2.8/debian/changelog @@ -1,3 +1,11 @@ +logtool (1.2.8-13.1) unstable; urgency=medium + + * Non-maintainer upload. + * Make requirement for root when building the package explicit. + (Closes: #1089378) + + -- Niels Thykier <[email protected]> Wed, 01 Jan 2025 09:35:36 +0000 + logtool (1.2.8-13) unstable; urgency=medium * src/mod_sound.h, src/ansi.c: add missing extern definition for lt_sound(). diff -u logtool-1.2.8/debian/control logtool-1.2.8/debian/control --- logtool-1.2.8/debian/control +++ logtool-1.2.8/debian/control @@ -3,6 +3,7 @@ Priority: optional Maintainer: Wouter Verhelst <[email protected]> Build-Depends: debhelper-compat (= 12) +Rules-Requires-Root: binary-targets Standards-Version: 3.9.8 Homepage: http://xjack.org/logtool/
OpenPGP_signature.asc
Description: OpenPGP digital signature
