Control: tags -1 patch On Sat, 7 Dec 2024 20:40:57 +0100 Niels Thykier <[email protected]> wrote:
Source: lpr Version: 1:2008.05.17.3+nmu3 Severity: important Tags: ftbfs Justification: FTBFS X-Debbugs-Cc: [email protected] User: [email protected] Usertags: rrr-no-as-default-issueDear maintainer, During a test rebuild for building packages with `Rules-Requires-Root: no` as the default in `dpkg`, lpr failed to rebuild. Log Summary: ------------------------------------------------------------------------------- [...]make[2]: Circular ../common_source/getcap.c <- ../common_source/getcap.o dependency dropped. make[2]: Circular ../common_source/vis.c <- ../common_source/vis.o dependency dropped. make[2]: Circular ../common_source/strlcpy.c <- ../common_source/strlcpy.o dependency dropped. make[2]: Circular ../common_source/strlcat.c <- ../common_source/strlcat.o dependency dropped. cc -o lpq lpq.o ../common_source/displayq.o ../common_source/common.o ../common_source/common_vars.o ../common_source/getcap.o ../common_source/vis.o ../common_source/strlcpy.o ../common_source/strlcat.omake[2]: Leaving directory '/<<PKGBUILDDIR>>/lpq' make[2]: Entering directory '/<<PKGBUILDDIR>>/lpr' make[2]: Circular lpr.c <- lpr.o dependency dropped.cc -I/../common_source -g -Wall -g -O2 -D_GNU_SOURCE -D__KAME__ -I../common_source -c -o lpr.o lpr.c lpr.c:49:19: warning: ‘rcsid’ defined but not used [-Wunused-const-variable=] 49 | static const char rcsid[] = "$OpenBSD: lpr.c,v 1.41 2007/04/07 21:57:27 stevesk Exp $";| ^~~~~lpr.c:40:19: warning: ‘copyright’ defined but not used [-Wunused-const-variable=]40 | static const char copyright[] = | ^~~~~~~~~make[2]: Circular ../common_source/startdaemon.c <- ../common_source/startdaemon.o dependency dropped. make[2]: Circular ../common_source/common.c <- ../common_source/common.o dependency dropped. make[2]: Circular ../common_source/common_vars.c <- ../common_source/common_vars.o dependency dropped. make[2]: Circular ../common_source/getcap.c <- ../common_source/getcap.o dependency dropped. make[2]: Circular ../common_source/strlcpy.c <- ../common_source/strlcpy.o dependency dropped. make[2]: Circular ../common_source/strlcat.c <- ../common_source/strlcat.o dependency dropped. cc -o lpr lpr.o ../common_source/startdaemon.o ../common_source/common.o ../common_source/common_vars.o ../common_source/getcap.o ../common_source/strlcpy.o ../common_source/strlcat.omake[2]: Leaving directory '/<<PKGBUILDDIR>>/lpr' make[2]: Entering directory '/<<PKGBUILDDIR>>/lprm'
Hi Please see attached as a patch.I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.
Note: If it comes to an NMU, then I will include the fix for #878450 (cross building) as well. If you do a maintainer upload, please consider applying that fix as well.
Best regards, Niels
diff -Nru lpr-2008.05.17.3+nmu3/debian/changelog lpr-2008.05.17.3+nmu3.1/debian/changelog --- lpr-2008.05.17.3+nmu3/debian/changelog 2024-07-31 19:53:51.000000000 +0200 +++ lpr-2008.05.17.3+nmu3.1/debian/changelog 2025-01-01 10:57:23.000000000 +0100 @@ -1,3 +1,11 @@ +lpr (1:2008.05.17.3+nmu3.1) unstable; urgency=medium + + * Non-maintainer upload. + * Make requirement for root when building the package explicit. + (Closes: #1089379) + + -- Niels Thykier <[email protected]> Wed, 01 Jan 2025 09:57:23 +0000 + lpr (1:2008.05.17.3+nmu3) unstable; urgency=medium * Non-maintainer upload. diff -Nru lpr-2008.05.17.3+nmu3/debian/control lpr-2008.05.17.3+nmu3.1/debian/control --- lpr-2008.05.17.3+nmu3/debian/control 2024-07-31 19:53:51.000000000 +0200 +++ lpr-2008.05.17.3+nmu3.1/debian/control 2025-01-01 10:57:23.000000000 +0100 @@ -3,6 +3,7 @@ Priority: optional Build-Depends: debhelper (>= 9) Maintainer: Adam Majer <[email protected]> +Rules-Requires-Root: binary-targets Standards-Version: 3.7.3 Vcs-Browser: https://salsa.debian.org/debian/lpr Vcs-Git: https://salsa.debian.org/debian/lpr.git
OpenPGP_signature.asc
Description: OpenPGP digital signature
