Control: tags -1 patch

On Sat, 7 Dec 2024 20:42:05 +0100 Niels Thykier <[email protected]> wrote:
Source: mactelnet
Version: 0.6.1-1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
mactelnet failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]


Hi

Please see attached as a patch.

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

This package can probably come truly rootless if the upstream makefile could be convinced to not pass `root` to `chown`. A common trick here is to use `$(USER):$(GROUP)` and then have the Debian package substitute USER/GROUP with `id -u`/`id -g` (which is a noop but allowed) and then rely on `dh_fixperms` + `dh_builddeb` to build the package with the correct ownership. However, it is was not a minimal patch, so I skipped that for the NMU.

Best regards,
Niels
diff -Nru mactelnet-0.6.1/debian/changelog mactelnet-0.6.1/debian/changelog
--- mactelnet-0.6.1/debian/changelog    2024-08-12 23:17:11.000000000 +0200
+++ mactelnet-0.6.1/debian/changelog    2025-01-01 19:26:36.000000000 +0100
@@ -1,3 +1,11 @@
+mactelnet (0.6.1-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Make requirement for root when building the package explicit.
+    (Closes: #1089381)
+
+ -- Niels Thykier <[email protected]>  Wed, 01 Jan 2025 18:26:36 +0000
+
 mactelnet (0.6.1-1) unstable; urgency=medium
 
   [ Håkon Nessjøen ]
diff -Nru mactelnet-0.6.1/debian/control mactelnet-0.6.1/debian/control
--- mactelnet-0.6.1/debian/control      2024-08-12 23:17:11.000000000 +0200
+++ mactelnet-0.6.1/debian/control      2025-01-01 19:19:53.000000000 +0100
@@ -3,6 +3,7 @@
 Priority: optional
 Maintainer: Håkon Nessjøen <[email protected]>
 Build-Depends: debhelper-compat (= 13), autoconf (>= 2.71), automake (>= 
1.16), autopoint (>= 0.21), libbsd-dev (>= 0.11), libssl-dev (>= 1.1), gettext 
(>=0.21)
+Rules-Requires-Root: binary-targets
 Standards-Version: 4.7.0
 Homepage: https://github.com/haakonnessjoen/MAC-Telnet/
 Vcs-Git: https://salsa.debian.org/debian/mactelnet.git

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to