Package: broadcom-sta-dkms Version: 6.30.223.271-5 Tags: patch User: [email protected] Usertags: appstream-modalias
In <URL: https://bugs.debian.org/838735 > the inclusion of AppStream metadata was discussed. The initial proposal was to match on individual PCI IDs explicitly, while the uploaded edition for some reason was set up to match any network controller. This was changed back in commit de507db882c322662e49f915c34f95e06d0ed14c uploaded as part of version 6.30.223.271-25. The current state make me believe it is time to re-enable AppStream for the broadcom-sta-dkms package, for example using this patch, which also hange to a reverse DNS style ID as required by AppStream, rename the XML file to match the new ID and install the file in the new location for AppStream files. diff --git a/debian/broadcom-sta-dkms.metainfo.xml b/debian/com.broadcom.linux.broadcom-sta.dkms.metainfo.xml similarity index 96% rename from debian/broadcom-sta-dkms.metainfo.xml rename to debian/com.broadcom.linux.broadcom-sta.dkms.metainfo.xml index a071867..a5ce73a 100644 --- a/debian/broadcom-sta-dkms.metainfo.xml +++ b/debian/com.broadcom.linux.broadcom-sta.dkms.metainfo.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <component> - <id>broadcom-sta-dkms</id> + <id>com.broadcom.linux.broadcom-sta.dkms</id> <metadata_license>PD</metadata_license> <name>broadcom-sta-dkms</name> <summary>Drivers for certain Broadcom WiFi network interfaces</summary> diff --git a/debian/rules b/debian/rules index ec7300e..9d587c4 100755 --- a/debian/rules +++ b/debian/rules @@ -17,7 +17,7 @@ dkms_target := usr/src/$(source_name)-$(version) ids_dir := usr/share/broadcom-sta # AppStream data -metadata_dir := usr/share/appdata +metadata_dir := usr/share/metainfo %: dh $@ @@ -36,8 +36,7 @@ install-dkms: install-tmp dh_installdirs -p $(dkms_package) $(dkms_target) dh_install -p $(dkms_package) debian/tmp/* $(dkms_target)/ dh_install -p $(dkms_package) debian/broadcom-sta.ids $(ids_dir)/ -# disable the AppStream metadata until it's clear how to work around confusion with the devices supported by the free driver -# dh_install -p $(dkms_package) debian/broadcom-sta-dkms.metainfo.xml $(metadata_dir)/ + dh_install -p $(dkms_package) debian/com.broadcom.linux.broadcom-sta.dkms.metainfo.xml $(metadata_dir)/ install-source: install-tmp dh_installdirs -p $(source_package) $(source_target) -- Happy hacking Petter Reinholdtsen
