Package: mini-dinstall
Version: 0.7.3
Severity: normal
Tags: upstream
X-Debbugs-Cc: [email protected]
Dear Maintainer,
When running mini-dinstall version 0.7.3, the program writes out a couple of
messages saying:
'chown_changes_files' is deprecated, please use 'restrict_changes_files'
instead
This is a actually message for the developer, since there is nothing the user
can do to prevent it from appearing.
I looked in the code for mini-dinstall, but I am not able to understand what's
going on. The deprecated dict entry 'chown_changes_files' is defined in line
404 of mini-dinstall. The deprecated message comes from line 457, that says:
if distributions[dist]['chown_changes_files'] is not None:
...
However that variable never gets the value None. It has the value False, and so
the execution proceeds inside the if clause.
A bit further down we have the code:
if distributions[dist]['restrict_changes_files'] is None:
distributions[dist]['restrict_changes_files'] =
distributions[dist]['chown_changes_files']
where apparently the newer option restrict_changes_files is set equal to the
older one if it is defined. Only this code is also not executed since the value
of distributions[dist]['chown_changes_files'] is False and not None.
I don't understand what the code is doing. If it comes from a set user option,
the error should tell the user to change it in the config file, but if the user
should not be alerted if the user has not set any chown_changes_files option.
I discovered another bug in the code, a forgotten .getName() -> .name change, I
have submitted a Pull Request on salsa for that one.
Cheers,
Morten
-- System Information:
Debian Release: 12.9
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.12.9+bpo-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.UTF-8), LANGUAGE=en_US
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages mini-dinstall depends on:
ii apt-utils 2.6.1
ii init-system-helpers 1.65.2
ii python3 3.11.2-1+b1
ii python3-apt 2.6.0
Versions of packages mini-dinstall recommends:
ii gpgv 2.2.40-1.1
Versions of packages mini-dinstall suggests:
ii debian-keyring 2022.12.24
-- no debconf information
