Hi Augustin,
thanks for your quick fix, again. Only I have a couple of
minor and not-so minor nits with respect to its
implementation, namely the newly introduced variable
`ispell-load-nomessage':
1. Personally and honestly, I don't think that a new variable
would be necessary here. As the doc string for function
`load' explains, its NOMESSAGE argument can always be
overridden by setting `force-load-message'. And I somewhat
doubt that a user really would like to have per-package
granularity for these (rather pesky) load messages.
2. Again rather personally, I don't think that it's necessary
to make this dependent on `noninteractive'. Just using
unconditional t for NOMESSAGE for all calls should be fine.
The main Debian hook in startup.el does the same, BTW:
(if (load "debian-startup" t t nil)
(debian-startup debian-emacs-flavor))
But these are my rather personal opinion and you can freely
ignore them. However, the name of your variable is asking for
trouble, since you somewhat violate the Emacs "namespacing
etiquette" by which only "ispell.el" would ever be allowed to
introduce new symbols with prefix "ispell-". So:
3. If you would like to keep that variable, you should consider
renaming it to `debian-ispell-load-nomessage'
Finally, one more suggestion that is rather unrelated: You
use this code:
(let ((ispell-default-file
"/var/cache/dictionaries-common/emacsen-ispell-default.el"))
(if (file-exists-p ispell-default-file)
(load ispell-default-file nil ispell-load-nomessage)))
to conditionally load that default file (again using a symbol
prefixed by "ispell-", but since it's let-bound, it's probably
OK). In my opinion you should be able to simplify that to
(load "/var/cache/dictionaries-common/emacsen-ispell-default.el"
t ispell-load-nomessage)
using t as NOERROR argument for `load'.
(I have tried signing up for Debian Salsa, hoping I could
provide feedback through the GitLab there, but I am not sure
whether me signing up is approved by the Salsa maintainers...)
Thanks again, regards
Jens
