Hi, On Tue, Mar 25, 2025 at 04:58:04PM +0100, Julien Plissonneau Duquène wrote: > Hi Guido, > > Thank you for looking into this issue. Unfortunately you closed your MR > before I got a chance to comment, and AIUI the proposed fix is just going to > replace this issue by another as now the re-checked out content won't match > what's in the source tarball. > > > As a reminder I've implemented a test case in the other merge request as > commit 1f0ad64e [1], could you please pick this commit and use it to test > your alternative attempts to resolve the issue to make sure they don't > introduce other issues?
The MR was merely to fix the current behavior of actually applying the result of `.git/info/attributes` to the just created repo. You e.g. couldn't `gbp buildpackage` with such a clone (as it has uncommitted changes) and a `git checkout -f` would get you into another state which you can't get out of afterwards which I don't think are the users expectations. So consider that a fix of the `--defuse-gitattributes=on` mode not an "attempt" to do something else. This is orthogonal to whether attributes should be defused by default or not. I've taken a chunk from your MR to add a test for the defusing step. Cheers, -- Guido > > Best regards, > > > [1]: > https://salsa.debian.org/agx/git-buildpackage/-/commit/1f0ad64e3f6fdaf24aa72d0da46934e0003dc6aa?merge_request_iid=38 > > -- > Julien Plissonneau Duquène
