Hello,

On Mon 16 Jun 2025 at 05:59pm -07, Xiyue Deng wrote:

> Sean Whitton <[email protected]> writes:
>
>> control: reassign -1 src:emacs
>> control: retitle -1 emacs: generate versioned Provides for all :core packages
>>
>> Hello,
>>
>> On Sun 13 Apr 2025 at 08:55pm -07, Xiyue Deng wrote:
>>
>>> Option 1 also sounds good to me.
>>
>> Cool.  I'm not planning to work on it but I can review patches.
>>
>
> I have made proof-of-concept patches as a pseudo-MR at [1] (this MR is
> against my own fork just for illustration).  Basically, it uses an Emacs
> script to generate Debian compatible versions from the builtin package
> list, which is integrated with `debian-sync' in debian/rules (similar to
> the handling of debian/copyright.in).  I'm currently making the provide
> list in emacs-common package which ships the compiled elisp files.
>
> Please review and comment.

Very interesting.

Have you considered using debhelper substvars for this?  Like how we
have ${elpa:Depends}.  It avoids needing a control.in.  A control.in
isn't the end of the world but it might be cleaner not to have one.

Don't sharpquote lambdas; unlike in CL, doing so will mean they don't
get compiled (I think).

You can rewrite the cond using cl-case or pcase.

Use cl-incf (just incf in Emacs 31) instead of setq and 1+.

I see you're using package--builtin-versions.  I'm not happy to be using
an internal variable -- it got us in trouble before!

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply via email to