Control: tags -1 = moreinfo Hi,
Packaging work is good, just a few issues:
- Build-Depends should have python3, not python3-all.
From dh_python3(1) manual page:
build-depend on python3 (Python application) or python3-all (Python
module) or python3-all-dev (Python extension),
- Depends does not need to include python3, the ${python3:Depends}
substitution variable does this for you.
- Remove override_dh_auto_test from d/rules. It is unnecessary as
debhelper will skip anyways when it doesn't find tests.
- The license of the packaging files in debian/ should match upstream's
license (Expat). This allows things like patches to be easily
integrated back into upstream when required.
- nice to have: add filenamemangle do d/watch
It would be nice to have d/watch look something like this:
version=4
opts="filenamemangle=s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%@PACKAGE@-$1.tar.gz%" \
https://github.com/mirkobrombin/FVS/tags .*/v?(\d.*)@ARCHIVE_EXT@
This allows the tarball to be downloaded to fvs-0.3.4.tar.gz
rather than v0.3.4.tar.gz.
--
Maytham
signature.asc
Description: This is a digitally signed message part
