Hello,

On Wed 13 Aug 2025 at 12:07pm +01, Ian Jackson wrote:

> However, I'm not convinced that sorting by version number here is
> right, in any case.  If there are multiple tags, why wouldn't we
> prefer the latest one by tag date?
>
> Empirically, git log --pretty=format:%D prints tags for the same
> commit in tagger date order, so we could just take the last.

I think you might have misread the code slightly.  Rather than only
comparing multiple tags on the same commit, the git log command in
find_last_tag returns all tags *reachable* from $branch_commit, and then
picks the one with the latest version number.

I am not sure whether latest tag by tagger date or Debian version number
would be more useful and/or principled so I suggest we just fix this bug
for now.  I've submitted an MR to that effect.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply via email to