Hi, If this feature were to be implemented as requested, I can imagine a scenario where someone who has until now not noticed salsa-CI might become aware of it only when git-debpush refuses to do what they want.
I'd guess that might well provoke a negative reaction, and the blame would either fall on git-debpush or salsa-CI, whereas it should really be pointed at whoever in their team enabled salsa-CI and then allowed it to end up in a state where it routinely fails. Might it be better to have an option for a pre-tag hook? That would then allow one to add checks of such things as the state of salsa-CI, in an opt-in manner where only people that know they want it will ever be told that they need to wait for CI to complete. Also, my workflow often involves repeatedly pushing slightly dodgy versions at a repo in my namespace until I am eventually happy with the outcome (including CI passing). Only then do I try to do an upload. If I was doing that with git-debpush, I'd want to be able to have it check the state of CI in the repo under _my_ namespace -- not in the upstream repo I was finally going to push the release commit into. I wouldn't want to have to wait for the CI to be run again, before the upload completes, especially if that requires me to be online from start to finish -- what it one goes offline before the extra CI run completes? Cheers, Phil. -- Philip Hands -- https://hands.com/~phil
