Philip Hands wrote: > If this feature were to be implemented as requested, I can imagine a > scenario where someone who has until now not noticed salsa-CI might > become aware of it only when git-debpush refuses to do what they want.
Please note what I wrote in > 3. Check if the current git HEAD (or if --branch was passed the HEAD > there) commit ID is in the list of pipelines, and if it has state > 'passed'. Alternatively skip rest of the check if the package does not > have pipelines and does not appear to be using CI. So person running git-debpush would only see message about Salsa CI not passing if the project is using Salsa CI. So if somebody "until now not noticed Salsa CI" because their project is not using it would not see anything. If the project is using it, then seeing the pipeline status is very much intentional and the whole point of the feature. > Might it be better to have an option for a pre-tag hook? So you would like all developers to manually install a pre-tag hook for themselves instead of having the git tag tool do this automatically? I think the people diligently installing pre-tag-hooks are likely the same who already know if their project is building and passing CI. The benefit of having this feature in git-debpush is to raise the CI status to people who might not otherwise make effort to check it, thus providing a nice convenience service to developers.
