Hi Chris,

>I haven't looked at the patch at all.

Sorry to jump in, I have attached my patch that I proposed for this issue in 
this mail. The patch basically just removes the random part from the filename 
(tmpkbd.XXXXX) while copying the file into the "setupdir" here[1].

>I think setupcon should just always use a deterministic filename in
>/etc/console-setup, and not bother with `tempfile` in this case.

As you suggest above, we could just use a deterministic name for the file 
instead of creating the file using `tempfile` to create the file and then 
renaming to remove the entropy in the filename.

[1] 
https://salsa.debian.org/installer-team/console-setup/-/blob/master/setupcon?ref_type=heads#L1258

Thanks and Regards,
Adithya Balakumar

Attachment: 0001-setupcon-Copy-temp-files-into-etc-console-setup-with.patch
Description: 0001-setupcon-Copy-temp-files-into-etc-console-setup-with.patch

Reply via email to