Package: unattended-upgrades
Version: 2.12
Severity: normal
Tags: patch
X-Debbugs-Cc: Santiago Vila <[email protected]>

Dear Michael, Santiago, et al,

data/50unattended-upgrades.Debian is outdated and has the following
problems:
  * #767208 - Misleading comment in /etc/apt/apt.conf.d/50unattended-upgrades:
    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767208
  * #1111238 - Macro ${distro_codename} is probably not derived from 
/etc/debian_version:
    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1111238
  * component example omits non-free-firmware
  * codename examples use jessie and buster
  * grammar can be improved

These are all fixed in the attached patch.

Similar fixes might need to be made to the other
data/50unattended-upgrades files.

Thank you!
Daniel Lewart
Urbana, Illinois
diff -ru a/data/50unattended-upgrades.Debian b/data/50unattended-upgrades.Debian
--- a/data/50unattended-upgrades.Debian 2025-01-01 11:22:25.000000000 -0600
+++ b/data/50unattended-upgrades.Debian 2025-09-16 00:00:00.000000000 -0500
@@ -7,19 +7,19 @@
 // keywords are wild cards.) The keywords originate from the Release
 // file, but several aliases are accepted.  The accepted keywords are:
 //   a,archive,suite (eg, "stable")
-//   c,component     (eg, "main", "contrib", "non-free")
+//   c,component     (eg, "main", "contrib", "non-free-firmware", "non-free")
 //   l,label         (eg, "Debian", "Debian-Security")
 //   o,origin        (eg, "Debian", "Unofficial Multimedia Packages")
-//   n,codename      (eg, "jessie", "jessie-updates")
-//     site          (eg, "http.debian.net")
+//   n,codename      (eg, "trixie", "trixie-security", "trixie-updates")
+//     site          (eg, "deb.debian.org")
 // The available values on the system are printed by the command
 // "apt-cache policy", and can be debugged by running
 // "unattended-upgrades -d" and looking at the log file.
 //
-// Within lines unattended-upgrades allows 2 macros whose values are
-// derived from /etc/debian_version:
+// Within lines unattended-upgrades allows two macros whose values are
+// derived from /etc/os-release or /usr/lib/os-release:
 //   ${distro_id}            Installed origin.
-//   ${distro_codename}      Installed codename (eg, "buster")
+//   ${distro_codename}      Installed codename (eg, "trixie")
 Unattended-Upgrade::Origins-Pattern {
         // Codename based matching:
         // This will follow the migration of a release through different
@@ -65,8 +65,8 @@
     // https://docs.python.org/3/howto/regex.html
 };
 
-// This option allows you to control if on a unclean dpkg exit
-// unattended-upgrades will automatically run 
+// This option allows you to control if unattended-upgrades will
+// automatically run on an unclean dpkg exit
 //   dpkg --force-confold --configure -a
 // The default is true, to ensure updates keep getting installed
 //Unattended-Upgrade::AutoFixInterruptedDpkg "true";

Reply via email to