Package: src:lomiri-content-hub
Version: 2.1.0-4
Severity: serious
Tags: ftbfs patch
Dear maintainer:
When this package is built with the nocheck build profile, the contents of
the package lomiri-content-hub-testability.deb is different, which is a
violation of policy:
Files in first .deb but not in second
-------------------------------------
-rw-r--r-- root/root /etc/apparmor.d/lomiri-content-hub-testability
-rw-r--r-- root/root
/usr/share/applications/lomiri-content-hub-test-exporter.desktop
-rw-r--r-- root/root
/usr/share/applications/lomiri-content-hub-test-importer.desktop
-rw-r--r-- root/root
/usr/share/applications/lomiri-content-hub-test-sharer.desktop
-rw-r--r-- root/root
/usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test-exporter.png
-rw-r--r-- root/root
/usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test-importer.png
-rw-r--r-- root/root
/usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test-sharer.png
-rw-r--r-- root/root
/usr/share/lomiri-content-hub/peers/lomiri-content-hub-test-exporter
-rw-r--r-- root/root
/usr/share/lomiri-content-hub/peers/lomiri-content-hub-test-importer
-rw-r--r-- root/root
/usr/share/lomiri-content-hub/peers/lomiri-content-hub-test-sharer
-rw-r--r-- root/root /usr/share/lomiri-content-hub/testability/data/Joker.vcf
-rw-r--r-- root/root /usr/share/lomiri-content-hub/testability/data/Music
Ringtone.ogg
-rw-r--r-- root/root
/usr/share/lomiri-content-hub/testability/data/Stark,_Tony.vcf
-rw-r--r-- root/root /usr/share/lomiri-content-hub/testability/data/clock.png
-rw-r--r-- root/root
/usr/share/lomiri-content-hub/testability/data/webbrowser-app.png
-rw-r--r-- root/root DEBIAN/conffiles
-rwxr-xr-x root/root /usr/bin/lomiri-content-hub-test-exporter
-rwxr-xr-x root/root /usr/bin/lomiri-content-hub-test-importer
-rwxr-xr-x root/root /usr/bin/lomiri-content-hub-test-sharer
-rwxr-xr-x root/root DEBIAN/postinst
-rwxr-xr-x root/root DEBIAN/postrm
Moreover, when building the package using DEB_BUILD_OPTIONS=nocheck
(*not* the nocheck build profile, only the variable), the package fails
to build:
Totally, 0 B can be reduced.
Now making symbolic links. creating
Making 0 links.
cd debian/tmp/usr/share/doc/lomiri-content-hub/qml/html/ && symlinks -rc .
dh_install
dh_install: warning: Cannot find (any matches for)
"usr/bin/lomiri-content-hub-test*" (tried in ., debian/tmp)
dh_install: warning: lomiri-content-hub-testability missing files:
usr/bin/lomiri-content-hub-test*
dh_install: warning: Cannot find (any matches for)
"usr/share/lomiri-content-hub/peers/lomiri-content-hub-test*" (tried in .,
debian/tmp)
dh_install: warning: lomiri-content-hub-testability missing files:
usr/share/lomiri-content-hub/peers/lomiri-content-hub-test*
dh_install: warning: Cannot find (any matches for)
"usr/share/applications/lomiri-content-hub-test*" (tried in ., debian/tmp)
dh_install: warning: lomiri-content-hub-testability missing files:
usr/share/applications/lomiri-content-hub-test*
dh_install: warning: Cannot find (any matches for)
"usr/share/lomiri-content-hub/testability/data" (tried in ., debian/tmp)
dh_install: warning: lomiri-content-hub-testability missing files:
usr/share/lomiri-content-hub/testability/data
dh_install: warning: Cannot find (any matches for)
"usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test*" (tried in .,
debian/tmp)
dh_install: warning: lomiri-content-hub-testability missing files:
usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test*
dh_install: error: missing files, aborting
make[1]: *** [debian/rules:63: override_dh_install] Error 255
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:28: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
The attached patch tries to address both things (please double check).
Thanks.
--- a/debian/rules
+++ b/debian/rules
@@ -11,11 +11,6 @@ PROJECT_DH_OPTIONS = --with click
# Disable coverage reporting, enable locally for introspecting test coverage
CONFIGURE_OPTS += -DENABLE_COVERAGE=OFF
-ifneq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
- CONFIGURE_OPTS += -DENABLE_TESTS=OFF
- DEB_BUILD_PROFILES += noinsttest
-endif
-
ifneq (,$(findstring nodoc,$(DEB_BUILD_OPTIONS)))
CONFIGURE_OPTS += -DENABLE_DOC=OFF
endif
@@ -46,9 +41,7 @@ endif
endif
override_dh_auto_install:
-ifneq (,$(findstring nocheck,$(DEB_BUILD_PROFILES)))
mkdir -p debian/lomiri-content-hub-testability
-endif
dh_auto_install --builddirectory=build-qt6 --buildsystem=cmake ..
dh_auto_install --builddirectory=build-qt5 --buildsystem=cmake ..
dh_apparmor -plomiri-content-hub-testability
--profile-name=lomiri-content-hub-testability
