Package: golang-github-google-goexpect
Version: 0.0~git20210430.ab937bf-2

Hi!  This package seems to have flaky tests which triggers testing
migration blockers, see what I believe are random build failures:

https://tests.reproducible-builds.org/debian/rb-pkg/forky/arm64/golang-github-google-goexpect.html
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/arm64/golang-github-google-goexpect.html
https://ci.debian.net/packages/g/golang-github-google-goexpect/testing/i386/64964676/
https://salsa.debian.org/go-team/packages/golang-github-google-goexpect/-/jobs/8113152

Looking at the error messages, this looks timing related so there is
probably a race condition somehwere.  Maybe the 20s timeout is not
sufficient on slow machines.

For flaky tests, I usually report these upstreams and mask it out of the
Debian build.  I initially thought keeping flaky tests around was
acceptable, but I've realized it causes serious Debian testing migration
pains so I believe we must not have any flaky tests in Debian.  Here is
an idea:

override_dh_auto_test:
        dh_auto_test $(DH_BUILD_OPTS) -- -skip=ExampleGExpect_SendSignal
        -dh_auto_test $(DH_BUILD_OPTS)

This allows the failure message to still become available in build logs,
for future references in bug reports.

If it only has happened on a particular arch, here is an idea:

ifneq (,$(filter $(DEB_TARGET_ARCH), ppc64el))
override_dh_auto_test:
        dh_auto_test $(DH_BUILD_OPTS) -- -skip=ExampleGExpect_SendSignal
        -dh_auto_test $(DH_BUILD_OPTS)
endif

For complex workarounds I have used this:

ifneq (,$(filter $(DEB_TARGET_ARCH), i386 ppc64el riscv64 s390x))
override_dh_auto_test:
ifneq (,$(filter $(DEB_TARGET_ARCH), i386))
        dh_auto_test $(DH_BUILD_OPT) -- --skip=TestAllocate
endif
ifneq (,$(filter $(DEB_TARGET_ARCH), ppc64el riscv64 s390x))
        dh_auto_test $(DH_BUILD_OPT) -- --skip='TestTreePersistent|TestBuffer'
endif
        -dh_auto_test $(DH_BUILD_OPT) -- --timeout=20m
endif

/Simon

Attachment: signature.asc
Description: PGP signature

Reply via email to