On Fri, 03 Oct 2025 01:12:57 +0100, Simon McVittie wrote:
This package build-depends on dbus-x11, and seems to be relying on X11 autolaunching to get a D-Bus session bus for its build-time tests: it does not seem to explicitly invoke dbus-launch or dbus-run-session.
dbus-launch is called by the upstream code:
t/01-marionette.t: my $dbus_output = `dbus-launch
2>/dev/null`;
t/01-marionette.t: my $dbus_output = `dbus-launch`;
t/01-marionette.t: diag("D-Bus appears to be broken. 'dbus-launch' was
unable to successfully complete:$?");
D-Bus X11 autolaunching is a poorly-understood legacy code path which
should be avoided where possible. Instead, please build-depend on
dbus-daemon and invoke a temporary D-Bus session bus explicitly, more
like this (untested):
override_dh_auto_test:
NO_NETWORK=1 RES_OPTIONS=attempts:0 http_proxy= \
xvfb-run -a \
dbus-run-session -- \
dh_auto_test -- TEST_FILES="$(TEST_FILES)"
This only requires a B-D on dbus-daemon <!nocheck>, which is a smaller
dependency than dbus-x11 and contains more robust code.
I've made these changes in d/control and d/rules, and the result is: 1) a warning during tests: # Starting test at Fri Oct 3 23:29:59 2025 [5657] Sandbox: CanCreateUserNamespace() clone() failure: EPERM # Version is Mozilla Firefox 140.3.1esr # XAUTHORITY is /tmp/xvfb-run.OekQAt/Xauthority # DISPLAY is :99 Can't exec "dbus-launch": No such file or directory at t/01-marionette.t line 564. # D-Bus appears to be broken. 'dbus-launch' was unable to successfully complete:-1 # Debian Version is forky/sid # Xvfb deb version is 2:21.1.18-2 2) the tests still passI was a bit worried about auopkgtests, as I have no idea how to add dbus-run-session there, but they pass as well.
A little bit later: Salsa CI is happy as well. So yeah, let's upload, even if I don't understand all details :) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe`-
signature.asc
Description: Digital Signature
