On Mon, Oct 13, 2025 at 12:54:00PM +0200, Santiago Vila wrote:
Hello. The attached patch would solve this issue.

Applied and uploaded, thanks.

I would fix it myself via team upload, but I can't even clone the
repository (see below).

I think the underlying problem is that docs/img/usage_fastapi_swagger.png
is not a real file but an external reference using GIT-LFS which still
points to github, probably because the salsa repo was created as a
filesystem snapshot of a lfs-enabled checkout.

I'm not sure this is even DFSG-compliant. Our source code is supposed
to be self-contained. I guess the right fix would involve dowloading
the released tar.gz from github:

https://github.com/art049/odmantic/archive/refs/tags/v1.0.2.tar.gz

where "usage_fastapi_swagger.png" is the real file, and then use
some +ds suffix for the new orig.tar.gz.

Yes, I ran into this with my previous upload and worked around it in some horrible way involving adding an upstream remote, but it's clearly unacceptable. I did as you suggest.

A fresh clone now _almost_ works, but you may have to argue with .gitattributes; I couldn't think of anything I could do about that. I found that the following procedure worked, though:

  $ git clone https://salsa.debian.org/python-team/packages/python-odmantic.git
  Cloning into 'python-odmantic'...
  remote: Enumerating objects: 360, done.
  remote: Counting objects: 100% (360/360), done.
  remote: Compressing objects: 100% (292/292), done.
  remote: Total 360 (delta 76), reused 306 (delta 44), pack-reused 0 (from 0)
  Receiving objects: 100% (360/360), 259.07 KiB | 470.00 KiB/s, done.
  Resolving deltas: 100% (76/76), done.
  Encountered 1 file that should have been a pointer, but wasn't:
          docs/img/usage_fastapi_swagger.png
  $ cd python-odmantic/
  $ dgit setup-gitattributes
  $ git restore .

--
Colin Watson (he/him)                              [[email protected]]

Reply via email to