On Tue, 2025-10-14 at 12:30 +0200, Gregor Riepl wrote:
> > > That would be much appreciated, thanks!
> > 
> > I looked at upstream and the project seems to be dead, no changes since 
> > 2016.
> 
> That's bad, considering that xdelta3 is a dependency of pristine-tar. :/

That was not obvious to me when you wrote this.

> > > override_dh_auto_configure:
> > >           dh_auto_configure $@ -- ax_cv_have_aligned_access_required=yes
> > 
> > Interesting, so it might not be broken at all?
> 
> I cleaned up the debugging code I had added to pristine-tar, installed the 
> xdelta3
> built with aligned access enforcement, and now the pristine-tar build 
> finishes successfully.

Good.

> Oh, and I just found out that the ax_check_aligned_access_required detection 
> script
> will "hide" the unaligned memory access crash if it's compiled with 
> optimization.
> When using -O0, it will crash with a bus error on sparc64, as it should.
> It's the same with a more recent version of the script[1].

OK, so the code remains broken.

> So, IMHO the cleanest fix should be to compile test script without 
> optimization, to
> ensure it's causing a bus error and correctly detect that the target cpu 
> requires
> aligned memory access.

Well, the bus error is well visible when running the xdelta3 testsuite.

> > > This makes the bus error go away. The pristine-tar build is still failing,
> > > but this might have other reasons.
> > 
> > You mean the unpatched source?
> 
> Sorry, which patch are you referring to?

The xdelta3 package has two patches, but they don't patch any C code as I just 
saw:

https://salsa.debian.org/debian/xdelta3/-/tree/master/debian/patches?ref_type=heads

But this was also a misunderstanding from my side. Since "pristine-tar" also 
refers
to a Git branch when maintaining package sources with Git, I thought you were 
referring
to the vanilla upstream source.

It was not clear to me that you were talking about the "pristine-tar" Debian 
package.


Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Reply via email to