Quoting Peter Michael Green (2025-09-28 12:39:34) > Package: meli > > I hope to update rust-nix to version 0.30 soon. I put together a patch > to make meli build with the new version. > > However, while doing so I ran into an issue that I belive indicates > broken code. Nix 0.30 removed the "copy" trait from the "PollFd" > type because "|PollFd| implementing |Copy| makes it easy to accidentally > refer to the wrong object after putting one into an array.". > > I added .clone calls to get the code building, but I belive that the > code is suffering from the issue that caused the nix developers > to remove the "copy" impl. The conditional logic is looking at the > original pollfd's, not the pollfds that have been mutated by > poll. This is IMO something you may want to discuss with upstream.
Thanks a lot! I made upstream aware of your concerns here, and they swiftly put together a fix. So please go ahead with the upgrade of nix (as far as this package goes) and simply bump severity when released to unstable, then I will cherry- pick upstream patch for supporting it here. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ * Sponsorship: https://ko-fi.com/drjones [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
