hi Syed,

in addition to Bastian's remark:

* changelog: revision 0.11.4-5 has been deleted entirely but actually
  is in the archive (but not in git?), please restore. Interestingly,
  that revision claims to have fixed #1108008 which is about the
  vendored copy of the crypto lib, but I'm not quite sure it actually
  did.

* patches: 001 shouldn't be needed anymore, if the package indeed
  uses the system crypto++ lib.
* patches: re. 002 & 003: if you're cherry-picking upstream commits
  (or an entire branch like in this case), please ensure that there's
  some comment or patch header indicating their origin.

* control: standards-version is out-of-date.
* control: the binary pkg still depends on "fuse", which is a
  transitional pkg; you may want to switch the dependency to fuse3.

* the debian dir includes some 'index.txt' file, probably committed
  by mistake.

* rules: no hardening?

* copyright: various unused license paragraphs.
* copyright: consider using vendor/cryptopp/vendor_cryptopp/* instead
  of that long list of files, and only list specific files for the
  exceptions that aren't public domain?

Attachment: pgpNmbav4lO9n.pgp
Description: OpenPGP digital signature

Reply via email to