Control: tag -1 upstream Control: forwarded -1 https://github.com/cockpit-project/cockpit/pull/22627
Hello Marc, Marc Leeman [2025-11-26 14:59 +0100]: > After writing some tests cases for our systems, I wrote a test that > checks for broken links is system directories: > > 00034_test-broken-symlinks : Check for broken symbolic links in system > directories... [FAIL] > ---- Output from 00034_test-broken-symlinks ---- > Broken symlinks detected in system directories. > /usr/share/cockpit/branding/arch/logo.png > /usr/share/cockpit/branding/arch/favicon.ico > /usr/share/cockpit/branding/arch/apple-touch-icon.png > -------------------------- > > The above files are symlinks to non-existing files and these are not > provided by any package. Thanks for spotting! > Description: Remove broken archlinux logo symlinks > Index: cockpit/Makefile.in > =================================================================== > --- cockpit.orig/Makefile.in > +++ cockpit/Makefile.in > @@ -5996,11 +5996,6 @@ uninstall-python: > %.metainfo.xml: %.metainfo.xml.in > $(AM_V_GEN) mkdir -p $(dir $@) && msgfmt --xml -d $(top_srcdir)/po > --template $< --output $@ > > -install-data-hook:: > - ln -sTfr $(DESTDIR)/usr/share/pixmaps/archlinux-logo.png > $(DESTDIR)$(archbrandingdir)/logo.png > - ln -sTfr $(DESTDIR)/usr/share/pixmaps/archlinux-logo.png > $(DESTDIR)$(archbrandingdir)/apple-touch-icon.png > - ln -sTfr $(DESTDIR)/usr/share/pixmaps/archlinux-logo.png > $(DESTDIR)$(archbrandingdir)/favicon.ico Let's not do it that way, I don't want patches in the Cockpit package. All the packaging is maintained upstream with strong CI. I sent https://github.com/cockpit-project/cockpit/pull/22627 instead, will be in the next release in ~ 2 weeks. Martin
