On Wed, Dec 03, 2025 at 05:21:13PM +0100, Santiago Vila wrote:
> On Wed, Dec 03, 2025 at 05:19:59PM +0200, Adrian Bunk wrote:
> > On Wed, Dec 03, 2025 at 03:03:02PM +0100, Santiago Vila wrote:
> > > The package still FTBFS after applying your patch.
> > > 
> > > (Maybe this time it's related to python 3.14, but uploading packages
> > > which are known to FTBFS is not nice).
> > 
> > I am getting:
> > 
> > ...
> > ============================= test session starts 
> > ==============================
> > platform linux -- Python 3.14.0, pytest-8.4.2, pluggy-1.6.0
> > ...
> > INTERNALERROR> ImportError: cannot import name '_c_internal_utils' from 
> > partially initialized module 'matplotlib' (most likely due to a circular 
> > import) (/usr/lib/python3/dist-packages/matplotlib/__init__.py)
> > ...
> > 
> > If this is the error you are seeing, then it will be fixed when 
> > matplotlib got rebuilt as part of the ongoing transition.
> 
> No, this is what I'm getting:

It would have saved me some time if you had provided a build log.

> project = <Project 
> '/tmp/pytest-of-sanvila/pytest-1/test_project_packages_path0'>
> 
>     def test_project_packages_path(project):
>         packages_path = project.environment.packages_path
>         version = ".".join(map(str, sys.version_info[:2]))
>         if os.name == "nt" and sys.maxsize <= 2**32:
>             assert packages_path.name == version + "-32"
>         else:
> >           assert packages_path.name == version
> E           AssertionError: assert '3.14' == '3.13'
> E             
> E             - 3.13
> E             ?    ^
> E             + 3.14
> E             ?    ^
> 
> tests/test_project.py:149: AssertionError
> 
> 
> So please cancel your NMU.

Why are you so insisting on cancellation?

Attached is a debdiff that avoids this problem of also testing a 
non-default Python.

> Thanks.

cu
Adrian
diffstat for pdm-2.23.1 pdm-2.23.1

 changelog                                                               |    8 
++
 control                                                                 |    2 
 patches/0001-fix-update-test-to-use-correct-platform-alias-for-ve.patch |   29 
++++++++++
 patches/series                                                          |    1 
 4 files changed, 39 insertions(+), 1 deletion(-)

diff -Nru pdm-2.23.1/debian/changelog pdm-2.23.1/debian/changelog
--- pdm-2.23.1/debian/changelog 2025-08-12 22:23:10.000000000 +0300
+++ pdm-2.23.1/debian/changelog 2025-11-30 05:26:38.000000000 +0200
@@ -1,3 +1,11 @@
+pdm (2.23.1-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Backport upstream FTBFS fix. (Closes: #1118428)
+  * Test only with the default python.
+
+ -- Adrian Bunk <[email protected]>  Sun, 30 Nov 2025 05:26:38 +0200
+
 pdm (2.23.1-2) unstable; urgency=medium
 
   * Team upload.
diff -Nru pdm-2.23.1/debian/control pdm-2.23.1/debian/control
--- pdm-2.23.1/debian/control   2025-07-28 15:40:05.000000000 +0300
+++ pdm-2.23.1/debian/control   2025-11-30 05:26:38.000000000 +0200
@@ -7,7 +7,7 @@
 Build-Depends: debhelper-compat (= 13),
                dh-sequence-python3,
                pybuild-plugin-pyproject,
-               python3-all,
+               python3,
                python3-blinker,
                python3-certifi,
                python3-dep-logic,
diff -Nru 
pdm-2.23.1/debian/patches/0001-fix-update-test-to-use-correct-platform-alias-for-ve.patch
 
pdm-2.23.1/debian/patches/0001-fix-update-test-to-use-correct-platform-alias-for-ve.patch
--- 
pdm-2.23.1/debian/patches/0001-fix-update-test-to-use-correct-platform-alias-for-ve.patch
   1970-01-01 02:00:00.000000000 +0200
+++ 
pdm-2.23.1/debian/patches/0001-fix-update-test-to-use-correct-platform-alias-for-ve.patch
   2025-11-30 05:21:35.000000000 +0200
@@ -0,0 +1,29 @@
+From 97c6af4a1c0e1c652e0a6474488e73193772c5e8 Mon Sep 17 00:00:00 2001
+From: Frost Ming <[email protected]>
+Date: Mon, 4 Aug 2025 08:24:01 +0800
+Subject: fix: update test to use correct platform alias for version comparison 
+ Close #3590
+
+Signed-off-by: Frost Ming <[email protected]>
+---
+ tests/cli/test_install.py | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/tests/cli/test_install.py b/tests/cli/test_install.py
+index e30c164e..2a326eba 100644
+--- a/tests/cli/test_install.py
++++ b/tests/cli/test_install.py
+@@ -394,8 +394,8 @@ def test_install_from_multi_target_lock(project, pdm, 
repository, nested, groups
+ def test_install_from_lock_with_higher_version(project, pdm, working_set):
+     project.add_dependencies(["django"])
+     pdm(["lock", "--platform", "manylinux_2_20_x86_64"], obj=project, 
strict=True)
+-    # linux is an alias for manylinux_2_17_x86_64 which is lower than the 
target
+-    project.environment.__dict__["spec"] = EnvSpec.from_spec("==3.11", 
"linux")
++    # Install with manylinux_2_17_x86_64 which is lower than the target
++    project.environment.__dict__["spec"] = EnvSpec.from_spec("==3.11", 
"manylinux_2_17_x86_64")
+     result = pdm(["install"], obj=project)
+     assert result.exit_code == 0
+     assert "WARNING: Found lock target" in result.stderr
+-- 
+2.30.2
+
diff -Nru pdm-2.23.1/debian/patches/series pdm-2.23.1/debian/patches/series
--- pdm-2.23.1/debian/patches/series    2025-07-28 15:40:05.000000000 +0300
+++ pdm-2.23.1/debian/patches/series    2025-11-30 05:26:36.000000000 +0200
@@ -1 +1,2 @@
 0002_fix_import.patch
+0001-fix-update-test-to-use-correct-platform-alias-for-ve.patch

Reply via email to