Niels Thykier:
Nicolas Boulenguez:
Package: dh-debputy
Version: 0.1.78
Severity: wishlist
Tags: patch

Hello.

The attachment lets debputy generate the (Static-)Built-Using fields
from manifest rules, replacing the dh-builtusing debhelper plugin.
It seems ready for a first review, if you are interested.


Hi Nicolas,

Thanks for proposing this patch and thanks for using `debputy`.

I am interested, but I am also finding myself without a lot of Debian time these days. You have to prod a bit for updates on my end.

[...]
'test_built_using.py' demonstrates various possible use cases. Advices
about the way to merge it into the test suite would be welcome.

[...]
Hi Nicolas,

I have gotten a bit further. I pushed some WIP code to the bug-1121339-built-using branch. It fails because I ported some code wrong/incompletely and I did not have energy to fix it. I will look at it later (some features are not available where they should be, I got a type error, not dealt with the `_w`/`_d` functions, etc.).

However, the tests are ported to the general layout I would want and are present in the `tests/test_built_using.py` file. It can be run with `py.test` (but will fail due to the above).

I have one TODO in it about the test running the detection code even though the package is not supposed to be built (real run would skip the `built-using` code here). We are talking here about the `01basic` test with the `package-disabled-by-arch` + `package-disabled-by-profile` code.

As I read the definitions, a real run of `debputy` (with the tweaked code) would never run the built-using code for these packages (in this port), since these packages are not "active". In other words, the test should really be looping over `manifest.active_packages` rather than `test_definition.packages` to match reality.

Best regards,
Niels



Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to